net/cert/cert_verify_proc_android.cc - Issue 14358023: Differentiate between VERIFY_FAILED and VERIFY_INCORRECT_KEY_USAGE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/cert_verify_proc_android.cc

Issue 14358023: Differentiate between VERIFY_FAILED and VERIFY_INCORRECT_KEY_USAGE. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Yep, joth was right. Hopefully this works. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/cert/cert_verify_proc_android.cc

diff --git a/net/cert/cert_verify_proc_android.cc b/net/cert/cert_verify_proc_android.cc

index 71456e26cca8b089449b6b1a4017de033af9b986..9a8acf76fa9d6f7e1504d1ecfff0af1574e25cb6 100644

--- a/net/cert/cert_verify_proc_android.cc

+++ b/net/cert/cert_verify_proc_android.cc

@@ -41,6 +41,9 @@ bool VerifyFromAndroidTrustManager(const std::vector<std::string>& cert_bytes,

case android::VERIFY_UNABLE_TO_PARSE:

verify_result->cert_status |= CERT_STATUS_INVALID;

break;

+ case android::VERIFY_INCORRECT_KEY_USAGE:

+ verify_result->cert_status |= CERT_STATUS_INVALID;

Ryan Sleevi 2013/04/25 18:36:50 I've confirmed this matches how we map CERT_TRUST_

+ break;

default:

NOTREACHED();

verify_result->cert_status |= CERT_STATUS_INVALID;