net/android/java/src/org/chromium/net/X509Util.java - Issue 14358023: Differentiate between VERIFY_FAILED and VERIFY_INCORRECT_KEY_USAGE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/android/java/src/org/chromium/net/X509Util.java

Issue 14358023: Differentiate between VERIFY_FAILED and VERIFY_INCORRECT_KEY_USAGE. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Yep, joth was right. Hopefully this works. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/android/java/src/org/chromium/net/X509Util.java

diff --git a/net/android/java/src/org/chromium/net/X509Util.java b/net/android/java/src/org/chromium/net/X509Util.java

index 15481e9e42cbeb0e5a175a719115fc86e893e1d7..a50399e424de40ab36c6ef5e8f6a94bccf9e31cd 100644

--- a/net/android/java/src/org/chromium/net/X509Util.java

+++ b/net/android/java/src/org/chromium/net/X509Util.java

@@ -195,7 +195,7 @@ public class X509Util {

try {

serverCertificates[0].checkValidity();

if (!verifyKeyUsage(serverCertificates[0]))

- return CertVerifyResultAndroid.VERIFY_FAILED;

+ return CertVerifyResultAndroid.VERIFY_INCORRECT_KEY_USAGE;

} catch (CertificateExpiredException e) {

return CertVerifyResultAndroid.VERIFY_EXPIRED;

} catch (CertificateNotYetValidException e) {