Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 14352005: Rename pnacl_file_host to nacl_file_host. (Closed)

Created:
7 years, 8 months ago by bbudge
Modified:
7 years, 8 months ago
CC:
chromium-reviews, Aaron Boodman, native-client-reviews_googlegroups.com, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Rename pnacl_file_host to nacl_file_host. This namespace is a logical place to put the OpenNaClExecutable function needed to fast load nexes. Since these aren't pnacl files, we should rename this namespace. BUG=188757 TEST=existing Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194972

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -327 lines) Patch
M chrome/browser/component_updater/pnacl/pnacl_component_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/nacl_host/nacl_file_host.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + chrome/browser/nacl_host/nacl_file_host.cc View 4 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/nacl_host/nacl_file_host_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/nacl_host/pnacl_file_host.h View 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/browser/nacl_host/pnacl_file_host.cc View 1 chunk +0 lines, -189 lines 0 comments Download
D chrome/browser/nacl_host/pnacl_file_host_unittest.cc View 1 chunk +0 lines, -73 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/pnacl_resources.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_support_extension/pnacl_component_crx_gen.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
bbudge
7 years, 8 months ago (2013-04-18 13:13:13 UTC) #1
jvoung (off chromium)
LGTM
7 years, 8 months ago (2013-04-18 15:06:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/14352005/1
7 years, 8 months ago (2013-04-18 15:16:32 UTC) #3
commit-bot: I haz the power
Presubmit check for 14352005-1 failed and returned exit status 1. INFO:root:Found 9 file(s). Running presubmit ...
7 years, 8 months ago (2013-04-18 15:16:39 UTC) #4
bbudge
+Brett for OWNERS review.
7 years, 8 months ago (2013-04-18 15:20:02 UTC) #5
bbudge
+John for OWNERS
7 years, 8 months ago (2013-04-18 16:55:04 UTC) #6
jam
lgtm
7 years, 8 months ago (2013-04-18 16:55:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/14352005/1
7 years, 8 months ago (2013-04-18 16:55:55 UTC) #8
commit-bot: I haz the power
7 years, 8 months ago (2013-04-18 18:28:36 UTC) #9
Message was sent while issue was closed.
Change committed as 194972

Powered by Google App Engine
This is Rietveld 408576698