Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9352)

Unified Diff: chrome/browser/nacl_host/pnacl_file_host_unittest.cc

Issue 14352005: Rename pnacl_file_host to nacl_file_host. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/nacl_host/pnacl_file_host_unittest.cc
diff --git a/chrome/browser/nacl_host/pnacl_file_host_unittest.cc b/chrome/browser/nacl_host/pnacl_file_host_unittest.cc
deleted file mode 100644
index 6e30c29bb5eebd19b86b5eac970b8a3886fd37cb..0000000000000000000000000000000000000000
--- a/chrome/browser/nacl_host/pnacl_file_host_unittest.cc
+++ /dev/null
@@ -1,73 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/browser/nacl_host/pnacl_file_host.h"
-
-#include "base/basictypes.h"
-#include "base/files/file_path.h"
-#include "base/files/scoped_temp_dir.h"
-#include "base/path_service.h"
-#include "base/test/scoped_path_override.h"
-#include "chrome/common/chrome_paths.h"
-
-#include "testing/gtest/include/gtest/gtest.h"
-
-using pnacl_file_host::PnaclCanOpenFile;
-
-// Try to pass a few funny filenames with a dummy pnacl directory set.
-TEST(PnaclFileHostTest, TestFilenamesWithPnaclPath) {
- base::ScopedTempDir scoped_tmp_dir;
- ASSERT_TRUE(scoped_tmp_dir.CreateUniqueTempDir());
-
- base::FilePath kDummyPnaclPath = scoped_tmp_dir.path();
- base::ScopedPathOverride pnach_dir_override(chrome::DIR_PNACL_COMPONENT,
- kDummyPnaclPath);
- ASSERT_TRUE(PathService::Get(chrome::DIR_PNACL_COMPONENT,
- &kDummyPnaclPath));
-
- // Check allowed strings, and check that the expected prefix is added.
- base::FilePath out_path;
- EXPECT_TRUE(PnaclCanOpenFile("pnacl_json", &out_path));
- base::FilePath expected_path = kDummyPnaclPath.Append(
- FILE_PATH_LITERAL("pnacl_public_pnacl_json"));
- EXPECT_EQ(out_path, expected_path);
-
- EXPECT_TRUE(PnaclCanOpenFile("x86_32_llc", &out_path));
- expected_path = kDummyPnaclPath.Append(
- FILE_PATH_LITERAL("pnacl_public_x86_32_llc"));
- EXPECT_EQ(out_path, expected_path);
-
- // Check character ranges.
- EXPECT_FALSE(PnaclCanOpenFile(".xchars", &out_path));
- EXPECT_FALSE(PnaclCanOpenFile("/xchars", &out_path));
- EXPECT_FALSE(PnaclCanOpenFile("x/chars", &out_path));
- EXPECT_FALSE(PnaclCanOpenFile("\\xchars", &out_path));
- EXPECT_FALSE(PnaclCanOpenFile("x\\chars", &out_path));
- EXPECT_FALSE(PnaclCanOpenFile("$xchars", &out_path));
- EXPECT_FALSE(PnaclCanOpenFile("%xchars", &out_path));
- EXPECT_FALSE(PnaclCanOpenFile("CAPS", &out_path));
- const char non_ascii[] = "\xff\xfe";
- EXPECT_FALSE(PnaclCanOpenFile(non_ascii, &out_path));
-
- // Check file length restriction.
- EXPECT_FALSE(PnaclCanOpenFile("thisstringisactuallywaaaaaaaaaaaaaaaaaaaaaaaa"
- "toolongwaytoolongwaaaaayyyyytoooooooooooooooo"
- "looooooooong",
- &out_path));
-
- // Other bad files.
- EXPECT_FALSE(PnaclCanOpenFile(std::string(), &out_path));
- EXPECT_FALSE(PnaclCanOpenFile(".", &out_path));
- EXPECT_FALSE(PnaclCanOpenFile("..", &out_path));
-#if defined(OS_WIN)
- EXPECT_FALSE(PnaclCanOpenFile("..\\llc", &out_path));
- EXPECT_FALSE(PnaclCanOpenFile("%SystemRoot%", &out_path));
- EXPECT_FALSE(PnaclCanOpenFile("%SystemRoot%\\explorer.exe", &out_path));
-#else
- EXPECT_FALSE(PnaclCanOpenFile("../llc", &out_path));
- EXPECT_FALSE(PnaclCanOpenFile("/bin/sh", &out_path));
- EXPECT_FALSE(PnaclCanOpenFile("$HOME", &out_path));
- EXPECT_FALSE(PnaclCanOpenFile("$HOME/.bashrc", &out_path));
-#endif
-}
« no previous file with comments | « chrome/browser/nacl_host/pnacl_file_host.cc ('k') | chrome/browser/renderer_host/chrome_render_message_filter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698