Issue 14335011: Revert 196728 "Websocket should fire 'error' event if no server ..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14335011: Revert 196728 "Websocket should fire 'error' event if no server ..." (Closed)

Created:
7 years, 8 months ago by ojan

Modified:
7 years, 8 months ago

Reviewers:
Li Yin

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 196728 "Websocket should fire 'error' event if no server ..." Looks like it made a layout test flaky. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showLargeExpectations=true&showExpectations=true&tests=http%252Ftests%252Fwebsocket%252Ftests%252Fhybi%252Fclose.html > Websocket should fire 'error' event if no server available > Implement OnError virtual function, when network is down, OnError can be invoked. > Send error code to render process from browser process through IPC. > > This patch depends on Blink side patch which can be found from https://codereview.chromium.org/14071008/ > > > BUG=128057 > TEST= > > Review URL: https://chromiumcodereview.appspot.com/10668018 TBR=li.yin@intel.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196855

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -97 lines)			Patch
M	trunk/src/AUTHORS	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/content/browser/renderer_host/socket_stream_dispatcher_host.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/content/browser/renderer_host/socket_stream_dispatcher_host.cc	View	1 chunk	+0 lines, -17 lines	0 comments	Download
M	trunk/src/content/browser/renderer_host/socket_stream_host.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/content/browser/renderer_host/socket_stream_host.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	trunk/src/content/common/socket_stream_dispatcher.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/content/common/socket_stream_dispatcher.cc	View	5 chunks	+0 lines, -22 lines	0 comments	Download
M	trunk/src/content/common/socket_stream_messages.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	trunk/src/net/socket_stream/socket_stream.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	trunk/src/net/socket_stream/socket_stream_unittest.cc	View	4 chunks	+8 lines, -4 lines	0 comments	Download
M	trunk/src/webkit/glue/websocketstreamhandle_delegate.h	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	trunk/src/webkit/glue/websocketstreamhandle_impl.cc	View	4 chunks	+0 lines, -16 lines	0 comments	Download
M	trunk/src/webkit/tools/test_shell/simple_socket_stream_bridge.cc	View	5 chunks	+0 lines, -20 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r196855.