Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: trunk/src/content/common/socket_stream_dispatcher.cc

Issue 14335011: Revert 196728 "Websocket should fire 'error' event if no server ..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/content/common/socket_stream_dispatcher.cc
===================================================================
--- trunk/src/content/common/socket_stream_dispatcher.cc (revision 196854)
+++ trunk/src/content/common/socket_stream_dispatcher.cc (working copy)
@@ -11,14 +11,11 @@
#include "base/lazy_instance.h"
#include "base/memory/ref_counted.h"
#include "base/message_loop.h"
-#include "base/string16.h"
-#include "base/utf_string_conversions.h"
#include "content/common/child_thread.h"
#include "content/common/socket_stream.h"
#include "content/common/socket_stream_handle_data.h"
#include "content/common/socket_stream_messages.h"
#include "googleurl/src/gurl.h"
-#include "net/base/net_errors.h"
#include "webkit/glue/websocketstreamhandle_bridge.h"
#include "webkit/glue/websocketstreamhandle_delegate.h"
@@ -51,7 +48,6 @@
void OnSentData(int amount_sent);
void OnReceivedData(const std::vector<char>& data);
void OnClosed();
- void OnFailed(int error_code, const char* error_msg);
private:
virtual ~IPCWebSocketStreamHandleBridge();
@@ -163,14 +159,6 @@
Release();
}
-void IPCWebSocketStreamHandleBridge::OnFailed(int error_code,
- const char* error_msg) {
- DVLOG(1) << "Bridge #" << socket_id_ << " OnFailed (error_code=" << error_code
- << ")";
- if (delegate_)
- delegate_->DidFail(handle_, error_code, ASCIIToUTF16(error_msg));
-}
-
void IPCWebSocketStreamHandleBridge::DoConnect(const GURL& url) {
DCHECK(child_thread_);
DCHECK_EQ(socket_id_, kNoSocketId);
@@ -219,7 +207,6 @@
IPC_MESSAGE_HANDLER(SocketStreamMsg_SentData, OnSentData)
IPC_MESSAGE_HANDLER(SocketStreamMsg_ReceivedData, OnReceivedData)
IPC_MESSAGE_HANDLER(SocketStreamMsg_Closed, OnClosed)
- IPC_MESSAGE_HANDLER(SocketStreamMsg_Failed, OnFailed)
IPC_MESSAGE_UNHANDLED(handled = false)
IPC_END_MESSAGE_MAP()
return handled;
@@ -274,13 +261,4 @@
DLOG(ERROR) << "No bridge for socket_id=" << socket_id;
}
-void SocketStreamDispatcher::OnFailed(int socket_id, int error_code) {
- IPCWebSocketStreamHandleBridge* bridge =
- IPCWebSocketStreamHandleBridge::FromSocketId(socket_id);
- if (bridge)
- bridge->OnFailed(error_code, net::ErrorToString(error_code));
- else
- DLOG(ERROR) << "No bridge for socket_id=" << socket_id;
-}
-
} // namespace content
« no previous file with comments | « trunk/src/content/common/socket_stream_dispatcher.h ('k') | trunk/src/content/common/socket_stream_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698