content/public/browser/service_worker_context.h - Issue 1432823003: Add a test to cover service worker update codepath when extension is updated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/service_worker_context.h

Issue 1432823003: Add a test to cover service worker update codepath when extension is updated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use set_force_update_on_page_load() + git cl format Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/service_worker_apitest.cc ('K') | « content/browser/service_worker/service_worker_context_wrapper.cc ('k') | extensions/browser/service_worker_manager.h » ('j') | extensions/browser/service_worker_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/service_worker_context.h

diff --git a/content/public/browser/service_worker_context.h b/content/public/browser/service_worker_context.h

index bac9ab620847a693819b127887f6107fcea28f66..080ca52fc9e2488fd0fae452419b010a53b2eb45 100644

--- a/content/public/browser/service_worker_context.h

+++ b/content/public/browser/service_worker_context.h

@@ -69,6 +69,7 @@ class ServiceWorkerContext {

virtual void GetAllOriginsInfo(const GetUsageInfoCallback& callback) = 0;

virtual void DeleteForOrigin(const GURL& origin_url,

const ResultCallback& callback) = 0;

+ virtual void SetForceUpdateOnPageLoadForOrigin(const GURL& origin) = 0;

Devlin 2015/11/11 17:10:29 Nit: This probably doesn't fall into the comment a

lazyboy 2015/11/11 22:34:03 Done.

// Returns true if a Service Worker registration exists that matches |url|,

// and if |other_url| falls inside the scope of the same registration. Note