extensions/browser/service_worker_manager.h - Issue 1432823003: Add a test to cover service worker update codepath when extension is updated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/service_worker_manager.h

Issue 1432823003: Add a test to cover service worker update codepath when extension is updated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use set_force_update_on_page_load() + git cl format Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/browser/service_worker_context.h ('K') | « content/public/browser/service_worker_context.h ('k') | extensions/browser/service_worker_manager.cc » ('j') | extensions/browser/service_worker_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/service_worker_manager.h

diff --git a/extensions/browser/service_worker_manager.h b/extensions/browser/service_worker_manager.h

index 2ba3ad10e1a1b82260d8ca07eb65a47c4bae616b..92d8cdcd854333e5a352c7318f63fc582a5f01b5 100644

--- a/extensions/browser/service_worker_manager.h

+++ b/extensions/browser/service_worker_manager.h

@@ -28,6 +28,11 @@ class ServiceWorkerManager : public ExtensionRegistryObserver {

void OnExtensionUninstalled(content::BrowserContext* browser_context,

const Extension* extension,

extensions::UninstallReason reason) override;

+ void OnExtensionWillBeInstalled(content::BrowserContext* browser_context,

+ const Extension* extension,

+ bool is_update,

+ bool from_ephemeral,

+ const std::string& old_name) override;

content::BrowserContext* browser_context_;