runtime/vm/os_macos.cc - Issue 1432603002: Return correct ActivationFrameAlignment for iOS simulator variants

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/os_macos.cc

Issue 1432603002: Return correct ActivationFrameAlignment for iOS simulator variants (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Address CL concerns Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/os_macos.cc

diff --git a/runtime/vm/os_macos.cc b/runtime/vm/os_macos.cc

index a7d3ee672364ef5fedf66fbb956ddf1a5bd1e546..aa6b9c855feff16563015e8d69b146ff1d42ed00 100644

--- a/runtime/vm/os_macos.cc

+++ b/runtime/vm/os_macos.cc

@@ -149,6 +149,12 @@ intptr_t OS::ActivationFrameAlignment() {

return 8;

#elif TARGET_ARCH_ARM64

return 16;

+#elif TARGET_ARCH_IA32

+ return 16; // iOS simulator

+#elif TARGET_ARCH_X64

+ return 16; // iOS simulator

+#else

+#error Unimplemented

#endif

#else // TARGET_OS_IOS

// OS X activation frames must be 16 byte-aligned; see "Mac OS X ABI

« no previous file with comments | « no previous file | no next file » | no next file with comments »