Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: runtime/vm/os_macos.cc

Issue 1432603002: Return correct ActivationFrameAlignment for iOS simulator variants (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Address CL concerns Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_OS_MACOS) 6 #if defined(TARGET_OS_MACOS)
7 7
8 #include "vm/os.h" 8 #include "vm/os.h"
9 9
10 #include <errno.h> // NOLINT 10 #include <errno.h> // NOLINT
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
142 142
143 143
144 intptr_t OS::ActivationFrameAlignment() { 144 intptr_t OS::ActivationFrameAlignment() {
145 #if TARGET_OS_IOS 145 #if TARGET_OS_IOS
146 #if TARGET_ARCH_ARM 146 #if TARGET_ARCH_ARM
147 // Even if we generate code that maintains a stronger alignment, we cannot 147 // Even if we generate code that maintains a stronger alignment, we cannot
148 // assert the stronger stack alignment because C++ code will not maintain it. 148 // assert the stronger stack alignment because C++ code will not maintain it.
149 return 8; 149 return 8;
150 #elif TARGET_ARCH_ARM64 150 #elif TARGET_ARCH_ARM64
151 return 16; 151 return 16;
152 #elif TARGET_ARCH_IA32
153 return 16; // iOS simulator
154 #elif TARGET_ARCH_X64
155 return 16; // iOS simulator
156 #else
157 #error Unimplemented
152 #endif 158 #endif
153 #else // TARGET_OS_IOS 159 #else // TARGET_OS_IOS
154 // OS X activation frames must be 16 byte-aligned; see "Mac OS X ABI 160 // OS X activation frames must be 16 byte-aligned; see "Mac OS X ABI
155 // Function Call Guide". 161 // Function Call Guide".
156 return 16; 162 return 16;
157 #endif // TARGET_OS_IOS 163 #endif // TARGET_OS_IOS
158 } 164 }
159 165
160 166
161 intptr_t OS::PreferredCodeAlignment() { 167 intptr_t OS::PreferredCodeAlignment() {
(...skipping 201 matching lines...) Expand 10 before | Expand all | Expand 10 after
363 } 369 }
364 370
365 371
366 void OS::Exit(int code) { 372 void OS::Exit(int code) {
367 exit(code); 373 exit(code);
368 } 374 }
369 375
370 } // namespace dart 376 } // namespace dart
371 377
372 #endif // defined(TARGET_OS_MACOS) 378 #endif // defined(TARGET_OS_MACOS)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698