Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 14316012: Apply the namespace migration for "savefile.default_directory" user-pref as well. (Closed)

Created:
7 years, 8 months ago by Haruki Sato
Modified:
7 years, 8 months ago
Reviewers:
achuithb
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Apply the namespace migration for "savefile.default_directory" user-pref as well. chrome_download_manager_delegate.cc might have propagated the value of "download.default_directory" to "savefile.default_directory" so we need to update it too. BUG=229248 TEST=trybots Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194830

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M chrome/browser/chromeos/preferences.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/preferences.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/preferences_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Haruki Sato
Thank you for your help no the previous changes. It turned out we have another ...
7 years, 8 months ago (2013-04-17 09:37:18 UTC) #1
achuithb
lgtm
7 years, 8 months ago (2013-04-17 18:48:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haruki@chromium.org/14316012/1
7 years, 8 months ago (2013-04-18 03:47:27 UTC) #3
commit-bot: I haz the power
7 years, 8 months ago (2013-04-18 07:13:19 UTC) #4
Message was sent while issue was closed.
Change committed as 194830

Powered by Google App Engine
This is Rietveld 408576698