Issue 14316012: Apply the namespace migration for "savefile.default_directory" user-pref as well.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14316012: Apply the namespace migration for "savefile.default_directory" user-pref as well. (Closed)

Created:
7 years, 8 months ago by Haruki Sato

Modified:
7 years, 8 months ago

Reviewers:
achuithb

CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Apply the namespace migration for "savefile.default_directory" user-pref as well. chrome_download_manager_delegate.cc might have propagated the value of "download.default_directory" to "savefile.default_directory" so we need to update it too. BUG=229248 TEST=trybots Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194830

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -0 lines)			Patch
M	chrome/browser/chromeos/preferences.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/preferences.cc	View	2 chunks	+12 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/preferences_unittest.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Haruki Sato

Thank you for your help no the previous changes. It turned out we have another ...

7 years, 8 months ago (2013-04-17 09:37:18 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haruki@chromium.org/14316012/1

7 years, 8 months ago (2013-04-18 03:47:27 UTC) #3

Message was sent while issue was closed.

Change committed as 194830

Expand Messages | Collapse Messages