Issue 14305026: ash: Remove use of ALLOW_THIS_IN_INITIALIZER_LIST.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14305026: ash: Remove use of ALLOW_THIS_IN_INITIALIZER_LIST. (Closed)

Created:
7 years, 7 months ago by tfarina

Modified:
7 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, sadrul, ben+watch_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, dcheng, oshima+watch_chromium.org, stevenjb+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ash: Remove use of ALLOW_THIS_IN_INITIALIZER_LIST. It's no longer providing value as the MSVC warning is disabled during compilation. Refer to bug for details. BUG=234765 TBR=ben@chromium.org

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -55 lines)			Patch
M	ash/desktop_background/desktop_background_controller.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/desktop_background/wallpaper_resizer.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ash/drag_drop/drag_drop_controller.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	ash/launcher/launcher_button.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/shelf/background_animator.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/shell/lock_view.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ash/shell/window_type_launcher.cc	View	2 chunks	+31 lines, -32 lines	0 comments	Download
M	ash/system/chromeos/network/network_icon_animation.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/system/tray/test_system_tray_delegate.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	ash/system/tray/tray_background_view.cc	View	1 chunk	+4 lines, -6 lines	0 comments	Download
M	ash/wm/activation_controller.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/wm/video_detector.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/wm/workspace/colored_window_controller.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/wm/workspace/workspace_manager.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download