Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 14287009: Land Recent QUIC Changes (Closed)

Created:
7 years, 8 months ago by ramant (doing other things)
Modified:
7 years, 8 months ago
Reviewers:
wtc, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, agl
Visibility:
Public.

Description

Land Recent QUIC Changes Bugfix infinite wait Merge internal change: 44685914 Some backports for chrome issue 12893018 Mostly cleaning up things for chrome style. Merge internal change: 44682570 rch: didn't merge the changes that make QuickClock an interface. Cleaned up couple of things in chrome while merging the changes. Add behaviour in the framer that enables visitor to make the framer stop proces sing a packet after the visitor processes a frame. Merge internal change: 44615956 Fix the stream close behaviour to not try to close the stream once again is the visitor closes the connection on Stream::OnClose. Merge internal change: 44560671 Small changes to QUIC client. Merge internal change: 44560573 Bug fix for entropy hash. Merge internal change: 44524848 Minor formatting changes to match internal code. Wire up delta_time_largest_observed_us in the ACK frames Merge internal change: 44518617 Minor formatting changes to match internal code. QUIC: step 9, certificate validation support. Note that certificate validation is currently synchronous. However, I put it in the crypto stream, rather than deeper in the crypto handshake code, so that the client handshake loop is very near by and thus it should be easy to make it asynchronous in the future. I also trimmed the includes of crypto_protocol.h and stopped the MAKE_TAG leaking out since preprocessor macros cannot be namespaced. Merge internal change: 44509151 R=rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196653

Patch Set 1 #

Patch Set 2 : Merge with ToT #

Patch Set 3 : changed number of client hellos #

Patch Set 4 : Added NET_EXPORT_PRIVATE for MakeQuicTag #

Total comments: 1

Patch Set 5 : Removed IMPORTANT from the comment. #

Patch Set 6 : Merge with Tot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+797 lines, -285 lines) Patch
M net/quic/congestion_control/tcp_cubic_sender.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/crypto/crypto_framer_test.cc View 14 chunks +26 lines, -29 lines 0 comments Download
M net/quic/crypto/crypto_handshake.h View 7 chunks +36 lines, -5 lines 0 comments Download
M net/quic/crypto/crypto_handshake.cc View 11 chunks +106 lines, -37 lines 0 comments Download
M net/quic/crypto/crypto_protocol.h View 3 chunks +48 lines, -34 lines 0 comments Download
M net/quic/crypto/crypto_server_config_protobuf.h View 1 chunk +1 line, -0 lines 0 comments Download
A net/quic/crypto/proof_verifier.h View 1 chunk +41 lines, -0 lines 0 comments Download
M net/quic/quic_connection.h View 2 chunks +10 lines, -6 lines 0 comments Download
M net/quic/quic_connection.cc View 9 chunks +54 lines, -26 lines 0 comments Download
M net/quic/quic_connection_test.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M net/quic/quic_crypto_client_stream.cc View 1 2 3 4 4 chunks +30 lines, -9 lines 0 comments Download
M net/quic/quic_crypto_client_stream_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/quic_crypto_server_stream_test.cc View 1 2 3 chunks +10 lines, -2 lines 0 comments Download
M net/quic/quic_data_writer.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_data_writer.cc View 1 chunk +14 lines, -2 lines 0 comments Download
M net/quic/quic_data_writer_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_framer.h View 3 chunks +15 lines, -11 lines 0 comments Download
M net/quic/quic_framer.cc View 15 chunks +103 lines, -43 lines 0 comments Download
M net/quic/quic_framer_test.cc View 12 chunks +93 lines, -9 lines 0 comments Download
M net/quic/quic_packet_creator_test.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M net/quic/quic_protocol.h View 1 2 3 2 chunks +12 lines, -3 lines 0 comments Download
M net/quic/quic_protocol.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M net/quic/quic_session.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/quic_utils.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/reliable_quic_stream.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/reliable_quic_stream.cc View 3 chunks +10 lines, -0 lines 0 comments Download
M net/quic/reliable_quic_stream_test.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.h View 2 chunks +4 lines, -0 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 3 chunks +20 lines, -20 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 5 chunks +66 lines, -7 lines 0 comments Download
M net/quic/test_tools/simple_quic_framer.cc View 2 chunks +12 lines, -6 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_client.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M net/tools/quic/quic_dispatcher.h View 1 chunk +1 line, -4 lines 0 comments Download
M net/tools/quic/quic_epoll_clock.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/tools/quic/quic_time_wait_list_manager.h View 1 chunk +8 lines, -9 lines 0 comments Download
M net/tools/quic/quic_time_wait_list_manager.cc View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
ramant (doing other things)
7 years, 8 months ago (2013-04-25 00:24:46 UTC) #1
ramant (doing other things)
+ wtc@ for crypto changes. wtc@ this CL is a merge of all the CLs ...
7 years, 8 months ago (2013-04-25 01:15:15 UTC) #2
wtc
Patch set 4 LGTM. https://codereview.chromium.org/14287009/diff/23002/net/quic/quic_crypto_client_stream.cc File net/quic/quic_crypto_client_stream.cc (right): https://codereview.chromium.org/14287009/diff/23002/net/quic/quic_crypto_client_stream.cc#newcode149 net/quic/quic_crypto_client_stream.cc:149: // TODO(rtenneti): IMPORTANT: in Chromium, ...
7 years, 8 months ago (2013-04-25 19:17:51 UTC) #3
ramant (doing other things)
7 years, 8 months ago (2013-04-25 23:04:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/14287009/34002
7 years, 8 months ago (2013-04-25 23:11:20 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=139936
7 years, 8 months ago (2013-04-26 03:13:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/14287009/34002
7 years, 8 months ago (2013-04-26 03:18:28 UTC) #7
commit-bot: I haz the power
7 years, 8 months ago (2013-04-26 07:31:49 UTC) #8
Message was sent while issue was closed.
Change committed as 196653

Powered by Google App Engine
This is Rietveld 408576698