Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2080)

Unified Diff: net/quic/quic_framer.h

Issue 14287009: Land Recent QUIC Changes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge with Tot Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_data_writer_test.cc ('k') | net/quic/quic_framer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_framer.h
diff --git a/net/quic/quic_framer.h b/net/quic/quic_framer.h
index efb61c5483f1db7db89639e1d06001c26fa527b5..ff5e4f84af1e87e312a46c1b84652655b402ed41 100644
--- a/net/quic/quic_framer.h
+++ b/net/quic/quic_framer.h
@@ -44,6 +44,9 @@ const size_t kQuicStreamPayloadLengthSize = 2;
// Size in bytes of the entropy hash sent in ack frames.
const size_t kQuicEntropyHashSize = 1;
+// Size in bytes reserved for the delta time of the largest observed
+// sequence number in ack frames.
+const size_t kQuicDeltaTimeLargestObservedSize = 4;
// Size in bytes reserved for the number of missing packets in ack frames.
const size_t kNumberOfMissingPacketsSize = 1;
@@ -90,24 +93,25 @@ class NET_EXPORT_PRIVATE QuicFramerVisitorInterface {
virtual void OnFecProtectedPayload(base::StringPiece payload) = 0;
// Called when a StreamFrame has been parsed.
- virtual void OnStreamFrame(const QuicStreamFrame& frame) = 0;
+ virtual bool OnStreamFrame(const QuicStreamFrame& frame) = 0;
- // Called when a AckFrame has been parsed.
- virtual void OnAckFrame(const QuicAckFrame& frame) = 0;
+ // Called when a AckFrame has been parsed. If OnAckFrame returns false,
+ // the framer will stop parsing the current packet.
+ virtual bool OnAckFrame(const QuicAckFrame& frame) = 0;
// Called when a CongestionFeedbackFrame has been parsed.
- virtual void OnCongestionFeedbackFrame(
+ virtual bool OnCongestionFeedbackFrame(
const QuicCongestionFeedbackFrame& frame) = 0;
// Called when a RstStreamFrame has been parsed.
- virtual void OnRstStreamFrame(const QuicRstStreamFrame& frame) = 0;
+ virtual bool OnRstStreamFrame(const QuicRstStreamFrame& frame) = 0;
// Called when a ConnectionCloseFrame has been parsed.
- virtual void OnConnectionCloseFrame(
+ virtual bool OnConnectionCloseFrame(
const QuicConnectionCloseFrame& frame) = 0;
// Called when a GoAwayFrame has been parsed.
- virtual void OnGoAwayFrame(const QuicGoAwayFrame& frame) = 0;
+ virtual bool OnGoAwayFrame(const QuicGoAwayFrame& frame) = 0;
// Called when FEC data has been parsed.
virtual void OnFecData(const QuicFecData& fec) = 0;
@@ -315,15 +319,15 @@ class NET_EXPORT_PRIVATE QuicFramer {
bool ProcessPacketSequenceNumber(QuicPacketSequenceNumber* sequence_number);
bool ProcessFrameData();
- bool ProcessStreamFrame();
+ bool ProcessStreamFrame(QuicStreamFrame* frame);
bool ProcessAckFrame(QuicAckFrame* frame);
bool ProcessReceivedInfo(ReceivedPacketInfo* received_info);
bool ProcessSentInfo(SentPacketInfo* sent_info);
bool ProcessQuicCongestionFeedbackFrame(
QuicCongestionFeedbackFrame* congestion_feedback);
- bool ProcessRstStreamFrame();
- bool ProcessConnectionCloseFrame();
- bool ProcessGoAwayFrame();
+ bool ProcessRstStreamFrame(QuicRstStreamFrame* frame);
+ bool ProcessConnectionCloseFrame(QuicConnectionCloseFrame* frame);
+ bool ProcessGoAwayFrame(QuicGoAwayFrame* frame);
bool DecryptPayload(QuicPacketSequenceNumber packet_sequence_number,
bool version_flag,
« no previous file with comments | « net/quic/quic_data_writer_test.cc ('k') | net/quic/quic_framer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698