Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1426953002: event_mon: support for GomaStats (Closed)

Created:
5 years, 1 month ago by pgervais
Modified:
5 years, 1 month ago
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@send-event-default-event
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

event_mon: support for GomaStats GomaStats can be passed as a protobuf object. BUG=513882 Committed: https://chromium.googlesource.com/infra/infra/+/e4c0c04ff999e1800d667ebe653567dd3081726a

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -10 lines) Patch
M infra_libs/event_mon/monitoring.py View 1 8 chunks +22 lines, -10 lines 0 comments Download
M infra_libs/event_mon/test/monitoring_test.py View 2 chunks +47 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1407143009 Patch 20001

Messages

Total messages: 7 (3 generated)
pgervais
This CL depends on https://chromiumcodereview.appspot.com/1407143009/
5 years, 1 month ago (2015-10-28 22:58:02 UTC) #2
Yoshisato Yanagisawa
lgtm with nit. https://codereview.chromium.org/1426953002/diff/1/infra_libs/event_mon/monitoring.py File infra_libs/event_mon/monitoring.py (right): https://codereview.chromium.org/1426953002/diff/1/infra_libs/event_mon/monitoring.py#newcode268 infra_libs/event_mon/monitoring.py:268: nit: unnecessary space?
5 years, 1 month ago (2015-10-29 02:42:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1426953002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1426953002/20001
5 years, 1 month ago (2015-10-29 17:21:18 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-10-29 17:23:30 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/e4c0c04ff999e1800d667ebe65356...

Powered by Google App Engine
This is Rietveld 408576698