Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1407143009: Added event_mon.set_default_event (Closed)

Created:
5 years, 1 month ago by pgervais
Modified:
5 years, 1 month ago
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Added event_mon.set_default_event This allows to change the template event used to compute all other events. BUG=513882 Committed: https://chromium.googlesource.com/infra/infra/+/eb48e8caff172b2621c66d0f7f87f4bfd8be4129

Patch Set 1 #

Total comments: 2

Patch Set 2 : set_default_event raises exception #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -16 lines) Patch
M infra_libs/event_mon/__init__.py View 1 chunk +1 line, -1 line 0 comments Download
M infra_libs/event_mon/config.py View 1 1 chunk +17 lines, -0 lines 0 comments Download
M infra_libs/event_mon/test/config_test.py View 1 7 chunks +29 lines, -15 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (5 generated)
pgervais
Simple modification, preparing for more.
5 years, 1 month ago (2015-10-28 22:31:34 UTC) #2
dsansome
lgtm https://chromiumcodereview.appspot.com/1407143009/diff/1/infra_libs/event_mon/config.py File infra_libs/event_mon/config.py (right): https://chromiumcodereview.appspot.com/1407143009/diff/1/infra_libs/event_mon/config.py#newcode175 infra_libs/event_mon/config.py:175: logging.error('A ChromeInfraEvent is required as the default event. ...
5 years, 1 month ago (2015-10-29 00:51:55 UTC) #3
Yoshisato Yanagisawa
I might not be the proper person to review this code. -myself +Sergey.
5 years, 1 month ago (2015-10-29 02:51:14 UTC) #6
pgervais
https://chromiumcodereview.appspot.com/1407143009/diff/1/infra_libs/event_mon/config.py File infra_libs/event_mon/config.py (right): https://chromiumcodereview.appspot.com/1407143009/diff/1/infra_libs/event_mon/config.py#newcode175 infra_libs/event_mon/config.py:175: logging.error('A ChromeInfraEvent is required as the default event. Got ...
5 years, 1 month ago (2015-10-29 17:11:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407143009/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407143009/20001
5 years, 1 month ago (2015-10-29 17:11:38 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-10-29 17:13:28 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/eb48e8caff172b2621c66d0f7f87f...

Powered by Google App Engine
This is Rietveld 408576698