Issue 14265007: Fix R= line handling when there is no value and improve presubmit TAG line regex

Issue 14265007: Fix R= line handling when there is no value and improve presubmit TAG line regex (Closed)

Created:
7 years, 8 months ago by M-A Ruel

Modified:
7 years, 8 months ago

Reviewers:
iannucci

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

More Reviews

Description

Fix R= line handling when there is no value and improve presubmit TAG line regex Make it more consistent across the tool. Using \s also includes \n, which confuses the tool. Add more tests. R=iannucci@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=195214

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added whitespace check. #

Patch Set 3 : Also check no trigger on whitespace #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -7 lines)			Patch
M	git_cl.py	View	1	4 chunks	+4 lines, -4 lines	0 comments	Download
M	presubmit_support.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/git_cl_test.py	View	1 2	1 chunk	+14 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

iannucci

lgtm https://codereview.chromium.org/14265007/diff/1/tests/git_cl_test.py File tests/git_cl_test.py (right): https://codereview.chromium.org/14265007/diff/1/tests/git_cl_test.py#newcode616 tests/git_cl_test.py:616: ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], 'foo\nBar\n\nR=c@c\nBUG='), Should there be tests to ...

7 years, 8 months ago (2013-04-18 18:25:16 UTC) #3

M-A Ruel

https://codereview.chromium.org/14265007/diff/1/tests/git_cl_test.py File tests/git_cl_test.py (right): https://codereview.chromium.org/14265007/diff/1/tests/git_cl_test.py#newcode616 tests/git_cl_test.py:616: ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], 'foo\nBar\n\nR=c@c\nBUG='), On 2013/04/18 18:25:16, iannucci wrote: > ...

7 years, 8 months ago (2013-04-19 16:58:42 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/14265007/9001

7 years, 8 months ago (2013-04-19 16:59:10 UTC) #5

Message was sent while issue was closed.

Change committed as 195214

Expand Messages | Collapse Messages