presubmit_support.py - Issue 14265007: Fix R= line handling when there is no value and improve presubmit TAG line regex

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: presubmit_support.py

Issue 14265007: Fix R= line handling when there is no value and improve presubmit TAG line regex (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Also check no trigger on whitespace Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: presubmit_support.py

diff --git a/presubmit_support.py b/presubmit_support.py

index fe1c2878c5c27b64e75dfd36e2b456ac84aa43af..5c3accbc55b148b1735f5782005898c44117634b 100755

--- a/presubmit_support.py

+++ b/presubmit_support.py

@@ -685,7 +685,7 @@ class Change(object):

# Matches key/value (or "tag") lines in changelist descriptions.

TAG_LINE_RE = re.compile(

- '^\s*(?P<key>[A-Z][A-Z_0-9]*)\s*=\s*(?P<value>.*?)\s*$')

+ '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')

scm = ''

def __init__(

« no previous file with comments | « git_cl.py ('k') | tests/git_cl_test.py » ('j') | no next file with comments »