Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 14251014: Handle retry-after-gc failures within KeyedLoadIC::Load and KeyedStoreIC::Store. (Closed)

Created:
7 years, 8 months ago by ulan
Modified:
7 years, 6 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Handle retry-after-gc failures within KeyedLoadIC::Load and KeyedStoreIC::Store. Returning retry-after-gc failure from these functions causes them to be re-executed after ic state change, which breaks stub computation assumptions. R=verwaest@chromium.org BUG=222301 TEST=mjsunit/array-bounds-check-removal.js --gc_interval=10 in x64.debug

Patch Set 1 #

Patch Set 2 : Rename functions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -2 lines) Patch
M src/heap-inl.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/ic.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime.h View 1 2 chunks +13 lines, -0 lines 0 comments Download
M src/runtime.cc View 1 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ulan
Please take a look. Once we agree on naming, I will add handling of more ...
7 years, 8 months ago (2013-04-15 16:17:05 UTC) #1
Toon Verwaest
7 years, 8 months ago (2013-04-16 12:13:24 UTC) #2
LGTM. Missing support for indexed properties (and perhaps calls), but as
discussed offline, it's fine to land that in a separate CL.

Powered by Google App Engine
This is Rietveld 408576698