Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Side by Side Diff: src/ic.cc

Issue 14251014: Handle retry-after-gc failures within KeyedLoadIC::Load and KeyedStoreIC::Store. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Rename functions Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/heap-inl.h ('k') | src/runtime.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1366 matching lines...) Expand 10 before | Expand all | Expand 10 after
1377 } 1377 }
1378 } else { 1378 } else {
1379 TRACE_GENERIC_IC(isolate(), "KeyedLoadIC", "force generic"); 1379 TRACE_GENERIC_IC(isolate(), "KeyedLoadIC", "force generic");
1380 } 1380 }
1381 ASSERT(!stub.is_null()); 1381 ASSERT(!stub.is_null());
1382 set_target(*stub); 1382 set_target(*stub);
1383 TRACE_IC("KeyedLoadIC", key, state, target()); 1383 TRACE_IC("KeyedLoadIC", key, state, target());
1384 } 1384 }
1385 1385
1386 1386
1387 return Runtime::GetObjectProperty(isolate(), object, key); 1387 return Runtime::GetObjectPropertyOrFail(isolate(), object, key);
1388 } 1388 }
1389 1389
1390 1390
1391 Handle<Code> KeyedLoadIC::ComputeLoadHandler(LookupResult* lookup, 1391 Handle<Code> KeyedLoadIC::ComputeLoadHandler(LookupResult* lookup,
1392 Handle<JSObject> receiver, 1392 Handle<JSObject> receiver,
1393 Handle<String> name) { 1393 Handle<String> name) {
1394 // Bail out if we didn't find a result. 1394 // Bail out if we didn't find a result.
1395 if (!lookup->IsProperty()) return Handle<Code>::null(); 1395 if (!lookup->IsProperty()) return Handle<Code>::null();
1396 1396
1397 // Compute a monomorphic stub. 1397 // Compute a monomorphic stub.
(...skipping 567 matching lines...) Expand 10 before | Expand all | Expand 10 after
1965 TRACE_GENERIC_IC(isolate(), "KeyedStoreIC", "not an object"); 1965 TRACE_GENERIC_IC(isolate(), "KeyedStoreIC", "not an object");
1966 } 1966 }
1967 } else { 1967 } else {
1968 TRACE_GENERIC_IC(isolate(), "KeyedStoreIC", "force generic"); 1968 TRACE_GENERIC_IC(isolate(), "KeyedStoreIC", "force generic");
1969 } 1969 }
1970 ASSERT(!stub.is_null()); 1970 ASSERT(!stub.is_null());
1971 set_target(*stub); 1971 set_target(*stub);
1972 TRACE_IC("KeyedStoreIC", key, state, target()); 1972 TRACE_IC("KeyedStoreIC", key, state, target());
1973 } 1973 }
1974 1974
1975 return Runtime::SetObjectProperty( 1975 return Runtime::SetObjectPropertyOrFail(
1976 isolate(), object , key, value, NONE, strict_mode); 1976 isolate(), object , key, value, NONE, strict_mode);
1977 } 1977 }
1978 1978
1979 1979
1980 Handle<Code> KeyedStoreIC::ComputeStoreMonomorphic(LookupResult* lookup, 1980 Handle<Code> KeyedStoreIC::ComputeStoreMonomorphic(LookupResult* lookup,
1981 StrictModeFlag strict_mode, 1981 StrictModeFlag strict_mode,
1982 Handle<JSObject> receiver, 1982 Handle<JSObject> receiver,
1983 Handle<String> name) { 1983 Handle<String> name) {
1984 // If the property has a non-field type allowing map transitions 1984 // If the property has a non-field type allowing map transitions
1985 // where there is extra room in the object, we leave the IC in its 1985 // where there is extra room in the object, we leave the IC in its
(...skipping 812 matching lines...) Expand 10 before | Expand all | Expand 10 after
2798 #undef ADDR 2798 #undef ADDR
2799 }; 2799 };
2800 2800
2801 2801
2802 Address IC::AddressFromUtilityId(IC::UtilityId id) { 2802 Address IC::AddressFromUtilityId(IC::UtilityId id) {
2803 return IC_utilities[id]; 2803 return IC_utilities[id];
2804 } 2804 }
2805 2805
2806 2806
2807 } } // namespace v8::internal 2807 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/heap-inl.h ('k') | src/runtime.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698