Issue 14246028: Clear the background_page_ready flag in DisableExtension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14246028: Clear the background_page_ready flag in DisableExtension. (Closed)

Created:
7 years, 8 months ago by msimonides

Modified:
7 years, 8 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Clear the background_page_ready flag in DisableExtension. I've used a conservative approach and only clear the background_page_ready flag. In the UnloadExtension method the whole extension_runtime_data_ for the extension is cleared, so maybe the same should be done here? BUG=232435 R=mpcomplete@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195468

Patch Set 1 #

Total comments: 1

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	chrome/browser/extensions/extension_service.cc	View		1 chunk	+4 lines, -0 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Matt Perry

lgtm https://codereview.chromium.org/14246028/diff/1/chrome/browser/extensions/extension_service.cc File chrome/browser/extensions/extension_service.cc (right): https://codereview.chromium.org/14246028/diff/1/chrome/browser/extensions/extension_service.cc#newcode970 chrome/browser/extensions/extension_service.cc:970: if (extensions::BackgroundInfo::HasBackgroundPage(extension)) nit: remove the if. Should be ...

7 years, 8 months ago (2013-04-19 18:50:44 UTC) #2

Matt Perry

BTW, it also looks like we could just reset the runtime state entirely, but let's ...

7 years, 8 months ago (2013-04-19 18:51:33 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msimonides@opera.com/14246028/1

7 years, 8 months ago (2013-04-22 06:35:35 UTC) #4

Message was sent while issue was closed.

Change committed as 195468

Expand Messages | Collapse Messages