Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 14246028: Clear the background_page_ready flag in DisableExtension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_service.cc
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc
index 8fc25936e35cbc882f8ff4f3fafdc3b9c56e78b5..c227e2dc690242cef45edbc7b4fc3ce6877b7a15 100644
--- a/chrome/browser/extensions/extension_service.cc
+++ b/chrome/browser/extensions/extension_service.cc
@@ -966,6 +966,10 @@ void ExtensionService::DisableExtension(
if (!extension)
return;
+ // Reset the background_page_ready flag
+ if (extensions::BackgroundInfo::HasBackgroundPage(extension))
Matt Perry 2013/04/19 18:50:44 nit: remove the if. Should be harmless to clear th
+ extension_runtime_data_[extension->id()].background_page_ready = false;
+
// Move it over to the disabled list. Don't send a second unload notification
// for terminated extensions being disabled.
disabled_extensions_.Insert(make_scoped_refptr(extension));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698