Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: Source/WebCore/loader/cache/CachedCSSStyleSheet.cpp

Issue 14210003: Simplify CachedResource::data (Closed) Base URL: svn://svn.chromium.org/blink/trunk/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/WebCore/loader/cache/CachedCSSStyleSheet.h ('k') | Source/WebCore/loader/cache/CachedFont.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebCore/loader/cache/CachedCSSStyleSheet.cpp
===================================================================
--- Source/WebCore/loader/cache/CachedCSSStyleSheet.cpp (revision 148397)
+++ Source/WebCore/loader/cache/CachedCSSStyleSheet.cpp (working copy)
@@ -94,32 +94,19 @@
return sheetText;
}
-void CachedCSSStyleSheet::data(PassRefPtr<ResourceBuffer> data, bool allDataReceived)
+void CachedCSSStyleSheet::checkNotify()
{
- if (!allDataReceived)
- return;
-
- m_data = data;
- setEncodedSize(m_data.get() ? m_data->size() : 0);
// Decode the data to find out the encoding and keep the sheet text around during checkNotify()
if (m_data) {
m_decodedSheetText = m_decoder->decode(m_data->data(), m_data->size());
m_decodedSheetText.append(m_decoder->flush());
}
- setLoading(false);
- checkNotify();
- // Clear the decoded text as it is unlikely to be needed immediately again and is cheap to regenerate.
- m_decodedSheetText = String();
-}
-void CachedCSSStyleSheet::checkNotify()
-{
- if (isLoading())
- return;
-
CachedResourceClientWalker<CachedStyleSheetClient> w(m_clients);
while (CachedStyleSheetClient* c = w.next())
c->setCSSStyleSheet(m_resourceRequest.url(), m_response.url(), m_decoder->encoding().name(), this);
+ // Clear the decoded text as it is unlikely to be needed immediately again and is cheap to regenerate.
+ m_decodedSheetText = String();
}
bool CachedCSSStyleSheet::canUseSheet(bool enforceMIMEType, bool* hasValidMIMEType) const
« no previous file with comments | « Source/WebCore/loader/cache/CachedCSSStyleSheet.h ('k') | Source/WebCore/loader/cache/CachedFont.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698