Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 14210003: Simplify CachedResource::data (Closed)

Created:
7 years, 8 months ago by Nate Chapin
Modified:
7 years, 8 months ago
CC:
blink-reviews, gavinp+loader_chromium.org
Visibility:
Public.

Description

Simplify CachedResource::data * Remove allDataReceived parameter from data(), do the end-of-load work in finishOnePart(), which is called by finish() and called directly for multipart loads. * Many subclass do work in data() only if allDataReceived is true. Do this work in checkNotify() instead. * Move calling setEncodedSize() into CachedResurce::data() instead of the subclasses, as it's duplicated in nearly every subclass. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148406

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -126 lines) Patch
M Source/WebCore/html/ImageDocument.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/WebCore/loader/ResourceLoader.cpp View 3 chunks +7 lines, -6 lines 0 comments Download
M Source/WebCore/loader/cache/CachedCSSStyleSheet.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/loader/cache/CachedCSSStyleSheet.cpp View 1 chunk +3 lines, -16 lines 0 comments Download
M Source/WebCore/loader/cache/CachedFont.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/loader/cache/CachedFont.cpp View 2 chunks +0 lines, -14 lines 0 comments Download
M Source/WebCore/loader/cache/CachedImage.h View 3 chunks +4 lines, -1 line 0 comments Download
M Source/WebCore/loader/cache/CachedImage.cpp View 4 chunks +16 lines, -10 lines 0 comments Download
M Source/WebCore/loader/cache/CachedRawResource.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/loader/cache/CachedRawResource.cpp View 3 chunks +3 lines, -7 lines 0 comments Download
M Source/WebCore/loader/cache/CachedResource.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/WebCore/loader/cache/CachedResource.cpp View 3 chunks +11 lines, -7 lines 0 comments Download
M Source/WebCore/loader/cache/CachedSVGDocument.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/loader/cache/CachedSVGDocument.cpp View 1 chunk +4 lines, -9 lines 0 comments Download
M Source/WebCore/loader/cache/CachedScript.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/loader/cache/CachedScript.cpp View 1 chunk +0 lines, -11 lines 0 comments Download
M Source/WebCore/loader/cache/CachedShader.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/loader/cache/CachedShader.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/WebCore/loader/cache/CachedTextTrack.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/loader/cache/CachedTextTrack.cpp View 1 chunk +2 lines, -10 lines 0 comments Download
M Source/WebCore/loader/cache/CachedXSLStyleSheet.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/loader/cache/CachedXSLStyleSheet.cpp View 1 chunk +1 line, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nate Chapin
7 years, 8 months ago (2013-04-15 23:05:18 UTC) #1
eseidel
A method named "data" with no return value makes no sense to me. :) But ...
7 years, 8 months ago (2013-04-15 23:08:50 UTC) #2
Nate Chapin
7 years, 8 months ago (2013-04-15 23:10:29 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r148406 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698