Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Unified Diff: chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.h

Issue 14208014: Simplify adding callbacks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.h
diff --git a/chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.h b/chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.h
index cbd270849c7f2991e2a3a2b7d4c8b613e9069b8a..84d1e7525ddb3e32f24ad3d9249e0ef946cfae03 100644
--- a/chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.h
+++ b/chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.h
@@ -5,6 +5,8 @@
#ifndef CHROME_BROWSER_UI_WEBUI_CHROMEOS_LOGIN_USER_IMAGE_SCREEN_HANDLER_H_
#define CHROME_BROWSER_UI_WEBUI_CHROMEOS_LOGIN_USER_IMAGE_SCREEN_HANDLER_H_
+#include <string>
+
#include "base/memory/weak_ptr.h"
#include "base/time.h"
#include "chrome/browser/chromeos/login/screens/user_image_screen_actor.h"
@@ -15,10 +17,6 @@
#include "ui/gfx/image/image_skia.h"
#include "ui/gfx/native_widget_types.h"
-namespace base {
-class ListValue;
-} // namespace base
-
namespace chromeos {
// WebUI implementation of UserImageScreenActor. It is used to interact
@@ -54,22 +52,23 @@ class UserImageScreenHandler : public UserImageScreenActor,
void SendProfileImage(const std::string& data_url);
// Sends image data to the page.
- void HandleGetImages(const base::ListValue* args);
+ void HandleGetImages();
// Handles photo taken with WebRTC UI.
- void HandlePhotoTaken(const base::ListValue* args);
+ void HandlePhotoTaken(const std::string& image_url);
// Handles camera presence check request.
- void HandleCheckCameraPresence(const base::ListValue* args);
+ void HandleCheckCameraPresence();
// Handles clicking on default user image.
- void HandleSelectImage(const base::ListValue* args);
+ void HandleSelectImage(const std::string& image_url,
+ const std::string& image_type);
// Called when user accept the image closing the screen.
- void HandleImageAccepted(const base::ListValue* args);
+ void HandleImageAccepted();
// Called when the user image screen has been loaded and shown.
- void HandleScreenShown(const base::ListValue* args);
+ void HandleScreenShown();
// Called when the camera presence check has been completed.
void OnCameraPresenceCheckDone();

Powered by Google App Engine
This is Rietveld 408576698