Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc

Issue 14208014: Simplify adding callbacks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc
diff --git a/chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc b/chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc
index 1f707255d5daf53f68fb44d9caa17e585f6de675..6ce65e6e5a4fc528b02fb3f1880dbc1613dc3689 100644
--- a/chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc
+++ b/chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc
@@ -144,9 +144,7 @@ void UserImageScreenHandler::OnProfileImageAbsent() {
}
}
-void UserImageScreenHandler::HandleGetImages(const base::ListValue* args) {
- DCHECK(args && !args->GetSize());
-
+void UserImageScreenHandler::HandleGetImages() {
base::ListValue image_urls;
for (int i = kFirstDefaultImageIndex; i < kDefaultImagesCount; ++i) {
scoped_ptr<base::DictionaryValue> image_data(new base::DictionaryValue);
@@ -169,13 +167,8 @@ void UserImageScreenHandler::HandleGetImages(const base::ListValue* args) {
OnProfileImageAbsent();
}
-void UserImageScreenHandler::HandlePhotoTaken(const base::ListValue* args) {
+void UserImageScreenHandler::HandlePhotoTaken(const std::string& image_url) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
- std::string image_url;
- if (!args || args->GetSize() != 1 || !args->GetString(0, &image_url))
- NOTREACHED();
- DCHECK(!image_url.empty());
-
std::string mime_type, charset, raw_data;
if (!net::DataURL::Parse(GURL(image_url), &mime_type, &charset, &raw_data))
NOTREACHED();
@@ -193,22 +186,12 @@ void UserImageScreenHandler::HandlePhotoTaken(const base::ListValue* args) {
image_decoder_->Start(task_runner);
}
-void UserImageScreenHandler::HandleCheckCameraPresence(
- const base::ListValue* args) {
- DCHECK(args->empty());
+void UserImageScreenHandler::HandleCheckCameraPresence() {
CheckCameraPresence();
}
-void UserImageScreenHandler::HandleSelectImage(const base::ListValue* args) {
- std::string image_url;
- std::string image_type;
- if (!args ||
- args->GetSize() != 2 ||
- !args->GetString(0, &image_url) ||
- !args->GetString(1, &image_type)) {
- NOTREACHED();
- return;
- }
+void UserImageScreenHandler::HandleSelectImage(const std::string& image_url,
+ const std::string& image_type) {
if (image_url.empty())
return;
@@ -225,8 +208,7 @@ void UserImageScreenHandler::HandleSelectImage(const base::ListValue* args) {
}
}
-void UserImageScreenHandler::HandleImageAccepted(const base::ListValue* args) {
- DCHECK(args && args->empty());
+void UserImageScreenHandler::HandleImageAccepted() {
if (!screen_)
return;
switch (selected_image_) {
@@ -248,8 +230,7 @@ void UserImageScreenHandler::HandleImageAccepted(const base::ListValue* args) {
}
}
-void UserImageScreenHandler::HandleScreenShown(const base::ListValue* args) {
- DCHECK(args && args->empty());
+void UserImageScreenHandler::HandleScreenShown() {
DCHECK(!screen_show_time_.is_null());
base::TimeDelta delta = base::Time::Now() - screen_show_time_;

Powered by Google App Engine
This is Rietveld 408576698