Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Unified Diff: chrome/browser/ui/webui/chromeos/login/enterprise_oauth_enrollment_screen_handler.cc

Issue 14208014: Simplify adding callbacks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chromeos/login/enterprise_oauth_enrollment_screen_handler.cc
diff --git a/chrome/browser/ui/webui/chromeos/login/enterprise_oauth_enrollment_screen_handler.cc b/chrome/browser/ui/webui/chromeos/login/enterprise_oauth_enrollment_screen_handler.cc
index ddf2e0b5d72b76fffee900f70ccff39d0d4b2e3c..0efbc6d95973fe7ad7796d9cedbe38fb1741e668 100644
--- a/chrome/browser/ui/webui/chromeos/login/enterprise_oauth_enrollment_screen_handler.cc
+++ b/chrome/browser/ui/webui/chromeos/login/enterprise_oauth_enrollment_screen_handler.cc
@@ -377,11 +377,7 @@ void EnterpriseOAuthEnrollmentScreenHandler::OnBrowsingDataRemoverDone() {
// EnterpriseOAuthEnrollmentScreenHandler, private -----------------------------
void EnterpriseOAuthEnrollmentScreenHandler::HandleClose(
- const base::ListValue* value) {
- std::string reason;
- CHECK_EQ(1U, value->GetSize());
- CHECK(value->GetString(0, &reason));
-
+ const std::string& reason) {
if (!controller_) {
NOTREACHED();
return;
@@ -398,28 +394,19 @@ void EnterpriseOAuthEnrollmentScreenHandler::HandleClose(
}
void EnterpriseOAuthEnrollmentScreenHandler::HandleCompleteLogin(
- const base::ListValue* value) {
+ const std::string& user) {
if (!controller_) {
NOTREACHED();
return;
}
-
- std::string user;
- if (!value->GetString(0, &user)) {
- NOTREACHED() << "Invalid user parameter from UI.";
- return;
- }
-
controller_->OnLoginDone(gaia::SanitizeEmail(user));
}
-void EnterpriseOAuthEnrollmentScreenHandler::HandleRetry(
- const base::ListValue* value) {
+void EnterpriseOAuthEnrollmentScreenHandler::HandleRetry() {
if (!controller_) {
NOTREACHED();
return;
}
-
controller_->OnRetry();
}

Powered by Google App Engine
This is Rietveld 408576698