Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2289)

Unified Diff: chrome/browser/ui/webui/chromeos/login/locally_managed_user_creation_screen_handler.h

Issue 14208014: Simplify adding callbacks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chromeos/login/locally_managed_user_creation_screen_handler.h
diff --git a/chrome/browser/ui/webui/chromeos/login/locally_managed_user_creation_screen_handler.h b/chrome/browser/ui/webui/chromeos/login/locally_managed_user_creation_screen_handler.h
index 9bc96f3a68844fe702db4a5ab7f07210c8ca300c..94fa6492247f2939d03d71ef31c2b9290bcfdf7b 100644
--- a/chrome/browser/ui/webui/chromeos/login/locally_managed_user_creation_screen_handler.h
+++ b/chrome/browser/ui/webui/chromeos/login/locally_managed_user_creation_screen_handler.h
@@ -6,6 +6,7 @@
#define CHROME_BROWSER_UI_WEBUI_CHROMEOS_LOGIN_LOCALLY_MANAGED_USER_CREATION_SCREEN_HANDLER_H_
#include "base/compiler_specific.h"
+#include "base/string16.h"
#include "chrome/browser/chromeos/login/reset_screen_actor.h"
#include "chrome/browser/ui/webui/chromeos/login/base_screen_handler.h"
#include "content/public/browser/web_ui.h"
@@ -34,10 +35,10 @@ class LocallyManagedUserCreationScreenHandler : public BaseScreenHandler {
// Starts managed user creation flow, with manager identified by
// |manager_id| and |manager_password|, and locally managed user that would
// have |display_name| and authenticated by the |managed_user_password|.
- virtual void RunFlow(string16& display_name,
- std::string& managed_user_password,
- std::string& manager_id,
- std::string& manager_password) = 0;
+ virtual void RunFlow(const string16& display_name,
+ const std::string& managed_user_password,
bartfab (slow) 2013/04/16 17:04:35 Since you are fixing up includes anyway: #include
ygorshenin1 2013/04/16 17:52:43 Done.
+ const std::string& manager_id,
+ const std::string& manager_password) = 0;
virtual void AbortFlow() = 0;
virtual void FinishFlow() = 0;
virtual void RetryLastStep() = 0;
@@ -69,12 +70,16 @@ class LocallyManagedUserCreationScreenHandler : public BaseScreenHandler {
private:
// WebUI message handlers.
- void HandleFinishLocalManagedUserCreation(const base::ListValue* args);
- void HandleAbortLocalManagedUserCreation(const base::ListValue* args);
- void HandleRetryLocalManagedUserCreation(const base::ListValue* args);
-
- void HandleCheckLocallyManagedUserName(const base::ListValue* args);
- void HandleRunLocallyManagedUserCreationFlow(const base::ListValue* args);
+ void HandleFinishLocalManagedUserCreation();
+ void HandleAbortLocalManagedUserCreation();
+ void HandleRetryLocalManagedUserCreation();
+
+ void HandleCheckLocallyManagedUserName(const string16& name);
+ void HandleRunLocallyManagedUserCreationFlow(
+ const string16& new_raw_user_name,
+ const std::string& new_user_password,
+ const std::string& manager_username,
+ const std::string& manager_password);
Delegate* delegate_;

Powered by Google App Engine
This is Rietveld 408576698