Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: src/IceAssembler.h

Issue 1419903002: Subzero: Refactor x86 register definitions to use the alias mechanism. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Add some comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/IceAssembler.cpp » ('j') | src/IceELFObjectWriter.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceAssembler.h
diff --git a/src/IceAssembler.h b/src/IceAssembler.h
index 5e7815d321718308611d1f995edb7d45b41f0099..70f7f41acf5a5cf5bb087f106aef86a3f6e75310 100644
--- a/src/IceAssembler.h
+++ b/src/IceAssembler.h
@@ -303,7 +303,7 @@ public:
bool needsTextFixup() const { return Buffer.needsTextFixup(); }
- void emitIASBytes() const;
+ void emitIASBytes(GlobalContext *Ctx) const;
bool getInternal() const { return IsInternal; }
void setInternal(bool Internal) { IsInternal = Internal; }
const IceString &getFunctionName() { return FunctionName; }
@@ -317,8 +317,8 @@ public:
AssemblerKind getKind() const { return Kind; }
protected:
- explicit Assembler(AssemblerKind Kind, GlobalContext *Ctx)
- : Kind(Kind), Allocator(), Ctx(Ctx), Buffer(*this) {}
+ explicit Assembler(AssemblerKind Kind)
+ : Kind(Kind), Allocator(), Buffer(*this) {}
private:
const AssemblerKind Kind;
@@ -339,7 +339,6 @@ private:
void installFixup(AssemblerFixup *F) { Buffer.installFixup(F); }
protected:
- GlobalContext *Ctx;
// Buffer's constructor uses the Allocator, so it needs to appear after it.
// TODO(jpp): dependencies on construction order are a nice way of shooting
// yourself in the foot. Fix this.
« no previous file with comments | « no previous file | src/IceAssembler.cpp » ('j') | src/IceELFObjectWriter.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698