Subzero: Refactor x86 register definitions to use the alias mechanism.

src/IceELFObjectWriter.cpp

Index: src/IceELFObjectWriter.cpp
diff --git a/src/IceELFObjectWriter.cpp b/src/IceELFObjectWriter.cpp
index 202ab0e208d65bea7abd5ed1ad9bfe8729870411..eb9fcf31d2f01e3e1ea39625a83f5d7b6b967bc2 100644
--- a/src/IceELFObjectWriter.cpp
+++ b/src/IceELFObjectWriter.cpp
@@ -405,7 +405,7 @@ void ELFObjectWriter::writeDataOfType(SectionType ST,
           AssemblerFixup NewFixup;
           NewFixup.set_position(Section->getCurrentSize());
           NewFixup.set_kind(RelocationKind);
-          const bool SuppressMangling = true;
+          constexpr bool SuppressMangling = true;
           NewFixup.set_value(Ctx.getConstantSym(
               Reloc->getOffset(), Reloc->getDeclaration()->mangleName(&Ctx),
               SuppressMangling));
@@ -523,7 +523,7 @@ template <typename ConstType> void ELFObjectWriter::writeConstantPool(Type Ty) {
   for (Constant *C : Pool) {
     if (!C->getShouldBePooled())
       continue;
-    auto Const = llvm::cast<ConstType>(C);
+    auto *Const = llvm::cast<ConstType>(C);
     std::string SymBuffer;
     llvm::raw_string_ostream SymStrBuf(SymBuffer);
     Const->emitPoolLabel(SymStrBuf, &Ctx);
@@ -596,7 +596,7 @@ void ELFObjectWriter::writeJumpTable(const JumpTableData &JT,
 
 void ELFObjectWriter::setUndefinedSyms(const ConstantList &UndefSyms) {
   for (const Constant *S : UndefSyms) {
-    const auto Sym = llvm::cast<ConstantRelocatable>(S);
+    const auto *Sym = llvm::cast<ConstantRelocatable>(S);
     const IceString &Name = Sym->getName();
     bool BadIntrinsic;
     const Intrinsics::FullIntrinsicInfo *Info =