content/browser/gpu/shader_disk_cache_unittest.cc - Issue 14197014: Add TestBrowserThreadBundle into RenderViewHostTestHarness. Kill some unnecessary real threads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/gpu/shader_disk_cache_unittest.cc

Issue 14197014: Add TestBrowserThreadBundle into RenderViewHostTestHarness. Kill some unnecessary real threads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: merged ToT Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/download/save_package_unittest.cc ('k') | content/browser/renderer_host/media/web_contents_video_capture_device_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/gpu/shader_disk_cache_unittest.cc

diff --git a/content/browser/gpu/shader_disk_cache_unittest.cc b/content/browser/gpu/shader_disk_cache_unittest.cc

index 93ed979e403f906107373f642ecaeebf9734f0b5..9c7061b62bb5a704d5bf746e8f9b7648b0e217db 100644

--- a/content/browser/gpu/shader_disk_cache_unittest.cc

+++ b/content/browser/gpu/shader_disk_cache_unittest.cc

@@ -6,7 +6,7 @@

#include "base/threading/thread.h"

#include "content/browser/browser_thread_impl.h"

#include "content/browser/gpu/shader_disk_cache.h"

-#include "content/public/test/test_browser_thread.h"

+#include "content/public/test/test_browser_thread_bundle.h"

#include "net/base/test_completion_callback.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -22,8 +22,7 @@ const char kCacheValue[] = "cached value";

class ShaderDiskCacheTest : public testing::Test {

public:

ShaderDiskCacheTest()

- : cache_thread_(BrowserThread::CACHE, &message_loop_),

- io_thread_(BrowserThread::IO, &message_loop_) {

+ : thread_bundle_(content::TestBrowserThreadBundle::IO_MAINLOOP) {

}

virtual ~ShaderDiskCacheTest() {}

@@ -42,9 +41,7 @@ class ShaderDiskCacheTest : public testing::Test {

}

base::ScopedTempDir temp_dir_;

- base::MessageLoopForIO message_loop_;

- TestBrowserThread cache_thread_;

- TestBrowserThread io_thread_;

+ content::TestBrowserThreadBundle thread_bundle_;

DISALLOW_COPY_AND_ASSIGN(ShaderDiskCacheTest);

};