Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: content/browser/download/save_package_unittest.cc

Issue 14197014: Add TestBrowserThreadBundle into RenderViewHostTestHarness. Kill some unnecessary real threads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merged ToT Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/save_package_unittest.cc
diff --git a/content/browser/download/save_package_unittest.cc b/content/browser/download/save_package_unittest.cc
index e40af08fb028bbfe961b6f446160f47ccea63ec9..bb5852b54a65b699b59d156cb748f8b943252831 100644
--- a/content/browser/download/save_package_unittest.cc
+++ b/content/browser/download/save_package_unittest.cc
@@ -9,7 +9,6 @@
#include "base/path_service.h"
#include "base/string_util.h"
#include "base/utf_string_conversions.h"
-#include "content/browser/browser_thread_impl.h"
#include "content/browser/download/save_package.h"
#include "content/browser/renderer_host/test_render_view_host.h"
#include "content/test/net/url_request_mock_http_job.h"
@@ -68,9 +67,6 @@ bool HasOrdinalNumber(const base::FilePath::StringType& filename) {
class SavePackageTest : public RenderViewHostImplTestHarness {
public:
- SavePackageTest() : browser_thread_(BrowserThread::UI, &message_loop_) {
- }
-
bool GetGeneratedFilename(bool need_success_generate_filename,
const std::string& disposition,
const std::string& url,
@@ -123,16 +119,12 @@ class SavePackageTest : public RenderViewHostImplTestHarness {
}
private:
- BrowserThreadImpl browser_thread_;
-
// SavePackage for successfully generating file name.
scoped_refptr<SavePackage> save_package_success_;
// SavePackage for failed generating file name.
scoped_refptr<SavePackage> save_package_fail_;
base::ScopedTempDir temp_dir_;
-
- DISALLOW_COPY_AND_ASSIGN(SavePackageTest);
};
static const struct {
« no previous file with comments | « content/browser/devtools/devtools_manager_unittest.cc ('k') | content/browser/gpu/shader_disk_cache_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698