Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(869)

Unified Diff: chrome/browser/extensions/script_badge_controller_unittest.cc

Issue 14197014: Add TestBrowserThreadBundle into RenderViewHostTestHarness. Kill some unnecessary real threads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merged ToT Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/script_badge_controller_unittest.cc
diff --git a/chrome/browser/extensions/script_badge_controller_unittest.cc b/chrome/browser/extensions/script_badge_controller_unittest.cc
index 14ada0789d812e5c8c26244f91a9c0decf272029..f28f3e8e221037ec878af4cf653333f599e28804 100644
--- a/chrome/browser/extensions/script_badge_controller_unittest.cc
+++ b/chrome/browser/extensions/script_badge_controller_unittest.cc
@@ -37,8 +37,6 @@
#include "chrome/browser/chromeos/settings/device_settings_service.h"
#endif
-using content::BrowserThread;
-
namespace extensions {
namespace {
@@ -46,8 +44,6 @@ class ScriptBadgeControllerTest : public ChromeRenderViewHostTestHarness {
public:
ScriptBadgeControllerTest()
: feature_override_(FeatureSwitch::script_badges(), true),
- ui_thread_(BrowserThread::UI, base::MessageLoop::current()),
- file_thread_(BrowserThread::FILE, base::MessageLoop::current()),
current_channel_(chrome::VersionInfo::CHANNEL_DEV) {}
virtual void SetUp() OVERRIDE {
@@ -56,6 +52,10 @@ class ScriptBadgeControllerTest : public ChromeRenderViewHostTestHarness {
// not use that for testing.
ChromeRenderViewHostTestHarness::SetUp();
+#if defined OS_CHROMEOS
+ test_user_manager_.reset(new chromeos::ScopedTestUserManager());
+#endif
+
Profile* profile =
Profile::FromBrowserContext(web_contents()->GetBrowserContext());
TestExtensionSystem* extension_system =
@@ -72,6 +72,13 @@ class ScriptBadgeControllerTest : public ChromeRenderViewHostTestHarness {
TabHelper::FromWebContents(web_contents())->location_bar_controller());
}
+ virtual void TearDown() OVERRIDE {
+#if defined OS_CHROMEOS
+ test_user_manager_.reset();
+#endif
+ ChromeRenderViewHostTestHarness::TearDown();
+ }
+
protected:
// Creates a test extension and adds it to |extension_service_|.
scoped_refptr<const Extension> AddTestExtension() {
@@ -98,14 +105,12 @@ class ScriptBadgeControllerTest : public ChromeRenderViewHostTestHarness {
private:
FeatureSwitch::ScopedOverride feature_override_;
- content::TestBrowserThread ui_thread_;
- content::TestBrowserThread file_thread_;
Feature::ScopedCurrentChannel current_channel_;
#if defined OS_CHROMEOS
chromeos::ScopedTestDeviceSettingsService test_device_settings_service_;
chromeos::ScopedTestCrosSettings test_cros_settings_;
- chromeos::ScopedTestUserManager test_user_manager_;
+ scoped_ptr<chromeos::ScopedTestUserManager> test_user_manager_;
#endif
};

Powered by Google App Engine
This is Rietveld 408576698