Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1701)

Unified Diff: chrome/browser/extensions/page_action_controller_unittest.cc

Issue 14197014: Add TestBrowserThreadBundle into RenderViewHostTestHarness. Kill some unnecessary real threads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merged ToT Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/page_action_controller_unittest.cc
diff --git a/chrome/browser/extensions/page_action_controller_unittest.cc b/chrome/browser/extensions/page_action_controller_unittest.cc
index f77ef6ee6edcb4a1a9f0d6936154a65a99e6f5f1..70358eb265473c68e74bbb1ac4a2fa2f9da4734a 100644
--- a/chrome/browser/extensions/page_action_controller_unittest.cc
+++ b/chrome/browser/extensions/page_action_controller_unittest.cc
@@ -28,19 +28,16 @@
#include "chrome/browser/chromeos/settings/device_settings_service.h"
#endif
-using content::BrowserThread;
-
namespace extensions {
namespace {
class PageActionControllerTest : public ChromeRenderViewHostTestHarness {
- public:
- PageActionControllerTest()
- : ui_thread_(BrowserThread::UI, base::MessageLoop::current()),
- file_thread_(BrowserThread::FILE, base::MessageLoop::current()) {}
-
+ protected:
virtual void SetUp() OVERRIDE {
ChromeRenderViewHostTestHarness::SetUp();
+#if defined OS_CHROMEOS
+ test_user_manager_.reset(new chromeos::ScopedTestUserManager());
+#endif
TabHelper::CreateForWebContents(web_contents());
// Create an ExtensionService so the PageActionController can find its
// extensions.
@@ -52,7 +49,13 @@ class PageActionControllerTest : public ChromeRenderViewHostTestHarness {
&command_line, base::FilePath(), false);
}
- protected:
+ virtual void TearDown() OVERRIDE {
+#if defined OS_CHROMEOS
+ test_user_manager_.reset();
+#endif
+ ChromeRenderViewHostTestHarness::TearDown();
+ }
+
int tab_id() {
return SessionID::IdForTab(web_contents());
}
@@ -60,13 +63,10 @@ class PageActionControllerTest : public ChromeRenderViewHostTestHarness {
ExtensionService* extension_service_;
private:
- content::TestBrowserThread ui_thread_;
- content::TestBrowserThread file_thread_;
-
#if defined OS_CHROMEOS
chromeos::ScopedTestDeviceSettingsService test_device_settings_service_;
chromeos::ScopedTestCrosSettings test_cros_settings_;
- chromeos::ScopedTestUserManager test_user_manager_;
+ scoped_ptr<chromeos::ScopedTestUserManager> test_user_manager_;
#endif
};

Powered by Google App Engine
This is Rietveld 408576698