Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: chrome/browser/chromeos/offline/offline_load_page_unittest.cc

Issue 14197014: Add TestBrowserThreadBundle into RenderViewHostTestHarness. Kill some unnecessary real threads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merged ToT Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/offline/offline_load_page_unittest.cc
diff --git a/chrome/browser/chromeos/offline/offline_load_page_unittest.cc b/chrome/browser/chromeos/offline/offline_load_page_unittest.cc
index db56c59b9ca9fba36b2737ac47fe7ba3a2150512..52b0e7c6eb5b706211c8eae4a5ab3f1154b4851d 100644
--- a/chrome/browser/chromeos/offline/offline_load_page_unittest.cc
+++ b/chrome/browser/chromeos/offline/offline_load_page_unittest.cc
@@ -8,10 +8,8 @@
#include "content/public/browser/interstitial_page.h"
#include "content/public/browser/navigation_controller.h"
#include "content/public/browser/web_contents.h"
-#include "content/public/test/test_browser_thread.h"
#include "content/public/test/web_contents_tester.h"
-using content::BrowserThread;
using content::InterstitialPage;
using content::WebContents;
using content::WebContentsTester;
@@ -52,13 +50,6 @@ class OfflineLoadPageTest : public ChromeRenderViewHostTestHarness {
CANCEL
};
- OfflineLoadPageTest()
- : ui_thread_(BrowserThread::UI, base::MessageLoop::current()),
- file_user_blocking_thread_(
- BrowserThread::FILE_USER_BLOCKING, base::MessageLoop::current()),
- io_thread_(BrowserThread::IO, base::MessageLoop::current()) {
- }
-
virtual void SetUp() {
ChromeRenderViewHostTestHarness::SetUp();
user_response_ = PENDING;
@@ -90,15 +81,12 @@ class OfflineLoadPageTest : public ChromeRenderViewHostTestHarness {
UserResponse user_response() const { return user_response_; }
private:
+ friend class TestOfflineLoadPage;
+
UserResponse user_response_;
- content::TestBrowserThread ui_thread_;
- content::TestBrowserThread file_user_blocking_thread_;
- content::TestBrowserThread io_thread_;
// Initializes / shuts down a stub CrosLibrary.
chromeos::ScopedStubCrosEnabler stub_cros_enabler_;
-
- DISALLOW_COPY_AND_ASSIGN(OfflineLoadPageTest);
};
void TestOfflineLoadPage::NotifyBlockingPageComplete(bool proceed) {

Powered by Google App Engine
This is Rietveld 408576698