Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Unified Diff: chrome/browser/chromeos/login/merge_session_load_page_unittest.cc

Issue 14197014: Add TestBrowserThreadBundle into RenderViewHostTestHarness. Kill some unnecessary real threads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merged ToT Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/merge_session_load_page_unittest.cc
diff --git a/chrome/browser/chromeos/login/merge_session_load_page_unittest.cc b/chrome/browser/chromeos/login/merge_session_load_page_unittest.cc
index be5778d6fa4c1bed8271a5c23c9b1742643c2fd0..54179319770b4e5b0c63de88443f9aa717fa3ebb 100644
--- a/chrome/browser/chromeos/login/merge_session_load_page_unittest.cc
+++ b/chrome/browser/chromeos/login/merge_session_load_page_unittest.cc
@@ -2,6 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include "base/run_loop.h"
#include "chrome/browser/chromeos/cros/cros_library.h"
#include "chrome/browser/chromeos/login/merge_session_load_page.h"
#include "chrome/browser/chromeos/login/user_manager.h"
@@ -11,10 +12,8 @@
#include "content/public/browser/interstitial_page.h"
#include "content/public/browser/navigation_controller.h"
#include "content/public/browser/web_contents.h"
-#include "content/public/test/test_browser_thread.h"
#include "content/public/test/web_contents_tester.h"
-using content::BrowserThread;
using content::InterstitialPage;
using content::WebContents;
using content::WebContentsTester;
@@ -48,12 +47,21 @@ class TestMergeSessionLoadPage : public MergeSessionLoadPage {
};
class MergeSessionLoadPageTest : public ChromeRenderViewHostTestHarness {
- public:
- MergeSessionLoadPageTest()
- : ui_thread_(BrowserThread::UI, base::MessageLoop::current()),
- file_user_blocking_thread_(
- BrowserThread::FILE_USER_BLOCKING, base::MessageLoop::current()),
- io_thread_(BrowserThread::IO, base::MessageLoop::current()) {
+ protected:
+ virtual void SetUp() OVERRIDE {
+ ChromeRenderViewHostTestHarness::SetUp();
+#if defined OS_CHROMEOS
+ test_user_manager_.reset(new chromeos::ScopedTestUserManager());
+#endif
+ }
+
+ virtual void TearDown() OVERRIDE {
+#if defined OS_CHROMEOS
+ // Clean up pending tasks that might depend on the user manager.
+ base::RunLoop().RunUntilIdle();
+ test_user_manager_.reset();
+#endif
+ ChromeRenderViewHostTestHarness::TearDown();
}
void Navigate(const char* url, int page_id) {
@@ -73,16 +81,10 @@ class MergeSessionLoadPageTest : public ChromeRenderViewHostTestHarness {
}
private:
- content::TestBrowserThread ui_thread_;
- content::TestBrowserThread file_user_blocking_thread_;
- content::TestBrowserThread io_thread_;
-
ScopedStubCrosEnabler stub_cros_enabler_;
ScopedTestDeviceSettingsService test_device_settings_service_;
ScopedTestCrosSettings test_cros_settings_;
- ScopedTestUserManager test_user_manager_;
-
- DISALLOW_COPY_AND_ASSIGN(MergeSessionLoadPageTest);
+ scoped_ptr<chromeos::ScopedTestUserManager> test_user_manager_;
};
TEST_F(MergeSessionLoadPageTest, MergeSessionPageNotShown) {
@@ -114,12 +116,12 @@ TEST_F(MergeSessionLoadPageTest, MergeSessionPageShown) {
ShowInterstitial(kURL2);
InterstitialPage* interstitial = GetMergeSessionLoadPage();
ASSERT_TRUE(interstitial);
- base::MessageLoop::current()->RunUntilIdle();
+ base::RunLoop().RunUntilIdle();
// Simulate merge session completion.
UserManager::Get()->SetMergeSessionState(
UserManager::MERGE_STATUS_DONE);
- base::MessageLoop::current()->RunUntilIdle();
+ base::RunLoop().RunUntilIdle();
// The URL remains to be URL2.
EXPECT_EQ(kURL2, web_contents()->GetURL().spec());

Powered by Google App Engine
This is Rietveld 408576698