Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Unified Diff: chrome/browser/captive_portal/captive_portal_tab_reloader_unittest.cc

Issue 14197014: Add TestBrowserThreadBundle into RenderViewHostTestHarness. Kill some unnecessary real threads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merged ToT Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/captive_portal/captive_portal_tab_reloader_unittest.cc
diff --git a/chrome/browser/captive_portal/captive_portal_tab_reloader_unittest.cc b/chrome/browser/captive_portal/captive_portal_tab_reloader_unittest.cc
index e09242d1f551bb328cc014ac85be994197904fa2..522adb8483e8a8c1e1b74a939b153ad2a45dfffd 100644
--- a/chrome/browser/captive_portal/captive_portal_tab_reloader_unittest.cc
+++ b/chrome/browser/captive_portal/captive_portal_tab_reloader_unittest.cc
@@ -12,7 +12,6 @@
#include "content/public/browser/interstitial_page.h"
#include "content/public/browser/interstitial_page_delegate.h"
#include "content/public/browser/web_contents.h"
-#include "content/public/test/test_browser_thread.h"
#include "googleurl/src/gurl.h"
#include "net/base/net_errors.h"
#include "net/cert/cert_status_flags.h"
@@ -89,16 +88,6 @@ class MockInterstitialPageDelegate : public content::InterstitialPageDelegate {
class CaptivePortalTabReloaderTest : public ChromeRenderViewHostTestHarness {
public:
- CaptivePortalTabReloaderTest()
- : ui_thread_(content::BrowserThread::UI, &message_loop_),
- file_user_blocking_thread_(content::BrowserThread::FILE_USER_BLOCKING,
- &message_loop_),
- io_thread_(content::BrowserThread::IO, &message_loop_) {
- }
-
- virtual ~CaptivePortalTabReloaderTest() {
- }
-
// testing::Test:
virtual void SetUp() OVERRIDE {
ChromeRenderViewHostTestHarness::SetUp();
@@ -118,10 +107,6 @@ class CaptivePortalTabReloaderTest : public ChromeRenderViewHostTestHarness {
TestCaptivePortalTabReloader& tab_reloader() { return *tab_reloader_.get(); }
private:
- content::TestBrowserThread ui_thread_;
- content::TestBrowserThread file_user_blocking_thread_;
- content::TestBrowserThread io_thread_;
-
scoped_ptr<TestCaptivePortalTabReloader> tab_reloader_;
};

Powered by Google App Engine
This is Rietveld 408576698