Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Unified Diff: chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc

Issue 14197014: Add TestBrowserThreadBundle into RenderViewHostTestHarness. Kill some unnecessary real threads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merged ToT Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/captive_portal/captive_portal_tab_reloader_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc
diff --git a/chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc b/chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc
index 7693f7fdf8e3938a9401cfec5c696be0d1a0321f..03563155494c961521dbb45f46d17b8b7910e081 100644
--- a/chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc
+++ b/chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc
@@ -17,7 +17,6 @@
#include "content/public/browser/render_view_host.h"
#include "content/public/browser/render_process_host.h"
#include "content/public/browser/web_contents.h"
-#include "content/public/test/test_browser_thread.h"
#include "net/base/net_errors.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -66,8 +65,7 @@ class CaptivePortalTabHelperTest : public ChromeRenderViewHostTestHarness {
public:
CaptivePortalTabHelperTest()
: tab_helper_(NULL),
- mock_reloader_(new testing::StrictMock<MockCaptivePortalTabReloader>),
- ui_thread_(content::BrowserThread::UI, &message_loop_) {
+ mock_reloader_(new testing::StrictMock<MockCaptivePortalTabReloader>) {
tab_helper_.SetTabReloaderForTest(mock_reloader_);
}
virtual ~CaptivePortalTabHelperTest() {}
@@ -220,8 +218,6 @@ class CaptivePortalTabHelperTest : public ChromeRenderViewHostTestHarness {
// Owned by |tab_helper_|.
testing::StrictMock<MockCaptivePortalTabReloader>* mock_reloader_;
- content::TestBrowserThread ui_thread_;
-
DISALLOW_COPY_AND_ASSIGN(CaptivePortalTabHelperTest);
};
« no previous file with comments | « no previous file | chrome/browser/captive_portal/captive_portal_tab_reloader_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698