Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 14189014: Minor cleanup in web_view_browsertest and remove repetitive code. (Closed)

Created:
7 years, 8 months ago by lazyboy
Modified:
7 years, 8 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Minor cleanup in web_view_browsertest and remove repetitive code. BUG=None TEST=Test clean up. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195184

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -57 lines) Patch
M chrome/browser/extensions/web_view_browsertest.cc View 4 chunks +41 lines, -57 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/web_view/download/embedder.js View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
lazyboy
+Fady for review.
7 years, 8 months ago (2013-04-19 02:52:16 UTC) #1
Fady Samuel
lgtm
7 years, 8 months ago (2013-04-19 03:22:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/14189014/1
7 years, 8 months ago (2013-04-19 08:11:35 UTC) #3
commit-bot: I haz the power
7 years, 8 months ago (2013-04-19 14:35:27 UTC) #4
Message was sent while issue was closed.
Change committed as 195184

Powered by Google App Engine
This is Rietveld 408576698