Minor cleanup in web_view_browsertest and remove repetitive code.

chrome/browser/extensions/web_view_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/stringprintf.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/automation/automation_util.h"
 #include "chrome/browser/extensions/extension_test_message_listener.h"
 #include "chrome/browser/extensions/platform_app_browsertest_util.h"
 #include "chrome/browser/prerender/prerender_link_manager.h"
@@ skipping 358 matching lines @@
                                        test_name.c_str())));
     done_listener.WaitUntilSatisfied();
     bool has_test_passed;
     EXPECT_TRUE(content::ExecuteScriptAndExtractBool(
                     embedder_web_contents,
                     "window.domAutomationController.send(hasTestPassed());",
                     &has_test_passed));
     ASSERT_TRUE(has_test_passed);
   }
 
+  content::WebContents* LoadGuest(const std::string& guest_path,
+                                  const std::string& app_path) {
+    GURL::Replacements replace_host;
+    std::string host_str("localhost");  // Must stay in scope with replace_host.
+    replace_host.SetHostStr(host_str);
+
+    GURL guest_url = test_server()->GetURL(guest_path);
+    guest_url = guest_url.ReplaceComponents(replace_host);
+
+    ui_test_utils::UrlLoadObserver guest_observer(
+        guest_url, content::NotificationService::AllSources());
+
+    ExtensionTestMessageListener guest_loaded_listener("guest-loaded", false);
+    LoadAndLaunchPlatformApp(app_path.c_str());
+    guest_observer.Wait();
+
+    content::Source<content::NavigationController> source =
+        guest_observer.source();
+    EXPECT_TRUE(source->GetWebContents()->GetRenderProcessHost()->IsGuest());
+
+    bool satisfied = guest_loaded_listener.WaitUntilSatisfied();
+    if (!satisfied)
+      return NULL;
+
+    content::WebContents* guest_web_contents = source->GetWebContents();
+    return guest_web_contents;
+  }
+
+ private:
   scoped_ptr<content::FakeSpeechRecognitionManager>
       fake_speech_recognition_manager_;
 };
 
 // http://crbug.com/176122: This test is flaky on Windows.
 #if defined(OS_WIN)
 #define MAYBE_Shim DISABLED_Shim
 #else
 #define MAYBE_Shim Shim
 #endif
 IN_PROC_BROWSER_TEST_F(WebViewTest, MAYBE_Shim) {
   ASSERT_TRUE(StartTestServer());
   ASSERT_TRUE(RunPlatformAppTest("platform_apps/web_view/shim")) << message_;
 }
 
 IN_PROC_BROWSER_TEST_F(WebViewTest, ShimSrcAttribute) {
   ASSERT_TRUE(RunPlatformAppTest("platform_apps/web_view/src_attribute"))
       << message_;
 }
 
 // This test verifies that prerendering has been disabled inside <webview>.
 // This test is here rather than in PrerenderBrowserTest for testing convenience
 // only. If it breaks then this is a bug in the prerenderer.
 IN_PROC_BROWSER_TEST_F(WebViewTest, NoPrerenderer) {
   ASSERT_TRUE(StartTestServer());
-  std::string host_str("localhost");  // Must stay in scope with replace_host.
-  GURL::Replacements replace_host;
-  replace_host.SetHostStr(host_str);
-
-  GURL guest_url = test_server()->GetURL(
-      "files/extensions/platform_apps/web_view/noprerenderer/guest.html");
-  guest_url = guest_url.ReplaceComponents(replace_host);
-
-  ui_test_utils::UrlLoadObserver guest_observer(
-      guest_url, content::NotificationService::AllSources());
-
-  ExtensionTestMessageListener guest_loaded_listener("guest-loaded", false);
-  LoadAndLaunchPlatformApp("web_view/noprerenderer");
-  guest_observer.Wait();
-
-  content::Source<content::NavigationController> source =
-      guest_observer.source();
-  EXPECT_TRUE(source->GetWebContents()->GetRenderProcessHost()->IsGuest());
-
-  ASSERT_TRUE(guest_loaded_listener.WaitUntilSatisfied());
-  content::WebContents* guest_web_contents = source->GetWebContents();
+  content::WebContents* guest_web_contents =
+      LoadGuest(
+          "files/extensions/platform_apps/web_view/noprerenderer/guest.html",
+          "web_view/noprerenderer");
   ASSERT_TRUE(guest_web_contents != NULL);
 
   PrerenderLinkManager* prerender_link_manager =
       PrerenderLinkManagerFactory::GetForProfile(
           Profile::FromBrowserContext(guest_web_contents->GetBrowserContext()));
   ASSERT_TRUE(prerender_link_manager != NULL);
   EXPECT_TRUE(prerender_link_manager->IsEmpty());
 }
 
 // This tests cookie isolation for packaged apps with webview tags. It navigates
@@ skipping 429 matching lines @@
             embedder_web_contents,
             "window.domAutomationController.send(getTestStatus())", &result));
     ASSERT_EQ(std::string("PASSED"), result);
 
     mock->WaitForSetMediaPermission();
   }
 }
 
 IN_PROC_BROWSER_TEST_F(WebViewTest, SpeechRecognition) {
   ASSERT_TRUE(StartTestServer());
-  std::string host_str("localhost");  // Must stay in scope with replace_host.
-  GURL::Replacements replace_host;
-  replace_host.SetHostStr(host_str);
+  content::WebContents* guest_web_contents = LoadGuest(
+      "files/extensions/platform_apps/web_view/speech/guest.html",
+      "web_view/speech");
+  ASSERT_TRUE(guest_web_contents);
 
-  GURL guest_url = test_server()->GetURL(
-      "files/extensions/platform_apps/web_view/speech/guest.html");
-  guest_url = guest_url.ReplaceComponents(replace_host);
-
-  ui_test_utils::UrlLoadObserver guest_observer(
-      guest_url, content::NotificationService::AllSources());
-
-  ExtensionTestMessageListener guest_loaded_listener("guest-loaded", false);
-  LoadAndLaunchPlatformApp("web_view/speech");
-  guest_observer.Wait();
-
-  content::Source<content::NavigationController> source =
-      guest_observer.source();
-  EXPECT_TRUE(source->GetWebContents()->GetRenderProcessHost()->IsGuest());
-
-  ASSERT_TRUE(guest_loaded_listener.WaitUntilSatisfied());
-  content::WebContents* guest_web_contents = source->GetWebContents();
   // Click on the guest (center of the WebContents), the guest is rendered in a
   // way that this will trigger clicking on speech recognition input mic.
   SimulateMouseClick(guest_web_contents, 0, WebKit::WebMouseEvent::ButtonLeft);
 
   string16 expected_title(ASCIIToUTF16("PASSED"));
   string16 error_title(ASCIIToUTF16("FAILED"));
   content::TitleWatcher title_watcher(guest_web_contents, expected_title);
   title_watcher.AlsoWaitForTitle(error_title);
   EXPECT_EQ(expected_title, title_watcher.WaitAndGetTitle());
 }
@@ skipping 68 matching lines @@
 #define MAYBE_NewWindow NewWindow
 #endif
 IN_PROC_BROWSER_TEST_F(WebViewTest, MAYBE_NewWindow) {
   ASSERT_TRUE(StartTestServer());  // For serving guest pages.
   ASSERT_TRUE(RunPlatformAppTest("platform_apps/web_view/newwindow"))
       << message_;
 }
 
 IN_PROC_BROWSER_TEST_F(WebViewTest, DownloadPermission) {
   ASSERT_TRUE(StartTestServer());  // For serving guest pages.
-  LoadAndLaunchPlatformApp("web_view/download");
-
-  GURL::Replacements replace_host;
-  std::string host_str("localhost");  // Must stay in scope with replace_host.
-  replace_host.SetHostStr(host_str);
-
-  // Grab the guest's WebContents.
-  GURL guest_url = test_server()->GetURL(
-      "files/extensions/platform_apps/web_view/download/guest.html");
-  guest_url = guest_url.ReplaceComponents(replace_host);
-  ui_test_utils::UrlLoadObserver observer(
-      guest_url, content::NotificationService::AllSources());
-  observer.Wait();
-  content::Source<content::NavigationController> source = observer.source();
-  EXPECT_TRUE(source->GetWebContents()->GetRenderProcessHost()->IsGuest());
-  content::WebContents* guest_web_contents = source->GetWebContents();
+  content::WebContents* guest_web_contents =
+      LoadGuest("files/extensions/platform_apps/web_view/download/guest.html",
+                "web_view/download");
+  ASSERT_TRUE(guest_web_contents);
 
   // Replace WebContentsDelegate with mock version so we can intercept download
   // requests.
   content::WebContentsDelegate* delegate = guest_web_contents->GetDelegate();
   MockDownloadWebContentsDelegate* mock_delegate =
       new MockDownloadWebContentsDelegate(delegate);
   guest_web_contents->SetDelegate(mock_delegate);
 
   // Start test.
   // 1. Guest requests a download that its embedder denies.
   EXPECT_TRUE(content::ExecuteScript(guest_web_contents,
                                      "startDownload('download-link-1')"));
   mock_delegate->WaitForCanDownload(false); // Expect to not allow.
   mock_delegate->Reset();
 
   // 2. Guest requests a download that its embedder allows.
   EXPECT_TRUE(content::ExecuteScript(guest_web_contents,
                                      "startDownload('download-link-2')"));
   mock_delegate->WaitForCanDownload(true); // Expect to allow.
   mock_delegate->Reset();
 
   // 3. Guest requests a download that its embedder ignores, this implies deny.
   EXPECT_TRUE(content::ExecuteScript(guest_web_contents,
                                      "startDownload('download-link-3')"));
   mock_delegate->WaitForCanDownload(false); // Expect to not allow.
 }