Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 14188054: Restore focus/activation after the root window has been completely deleted. (Closed)

Created:
7 years, 8 months ago by oshima
Modified:
7 years, 8 months ago
Reviewers:
Jun Mukai
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Restore focus/activation after the root window has been completely deleted. Otherwise restoring focused/active window may try to use stale display. BUG=229158 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195552

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -33 lines) Patch
M ash/display/display_controller.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M ash/display/display_controller.cc View 1 2 4 chunks +75 lines, -1 line 0 comments Download
M ash/root_window_controller.cc View 2 chunks +0 lines, -32 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
oshima
7 years, 8 months ago (2013-04-19 22:39:16 UTC) #1
Jun Mukai
lgtm
7 years, 8 months ago (2013-04-19 22:50:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/14188054/2001
7 years, 8 months ago (2013-04-19 23:10:48 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=104930
7 years, 8 months ago (2013-04-20 00:17:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/14188054/2001
7 years, 8 months ago (2013-04-20 00:33:14 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-20 01:48:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/14188054/27001
7 years, 8 months ago (2013-04-20 02:03:38 UTC) #7
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 8 months ago (2013-04-20 02:05:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/14188054/27001
7 years, 8 months ago (2013-04-20 02:23:00 UTC) #9
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-20 03:05:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/14188054/27001
7 years, 8 months ago (2013-04-20 05:38:42 UTC) #11
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-20 05:45:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/14188054/27001
7 years, 8 months ago (2013-04-20 06:57:41 UTC) #13
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-20 07:06:37 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/14188054/27001
7 years, 8 months ago (2013-04-22 16:40:22 UTC) #15
commit-bot: I haz the power
7 years, 8 months ago (2013-04-22 18:02:54 UTC) #16
Message was sent while issue was closed.
Change committed as 195552

Powered by Google App Engine
This is Rietveld 408576698