Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1795)

Unified Diff: chrome/android/java/res/layout/data_use_dialog.xml

Issue 1418473005: Add a dialog UI for Data Use accounting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@freighterSnackbar
Patch Set: remove we Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/data_use_dialog.xml
diff --git a/chrome/android/java/res/layout/data_use_dialog.xml b/chrome/android/java/res/layout/data_use_dialog.xml
new file mode 100644
index 0000000000000000000000000000000000000000..2141e1d32896b9e1df62526d44bd1136fcb6af8d
--- /dev/null
+++ b/chrome/android/java/res/layout/data_use_dialog.xml
@@ -0,0 +1,13 @@
+<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
newt (away) 2015/11/06 20:40:36 missing copyright
megjablon 2015/11/06 23:41:40 Done.
+ android:layout_height="wrap_content"
+ android:layout_width="fill_parent"
newt (away) 2015/11/06 20:40:36 s/fill_parent/match_parent/ (they mean the same th
megjablon 2015/11/06 23:41:40 Done.
+ android:paddingStart="18dp"
+ android:paddingTop="8dp" >
+
+ <CheckBox
newt (away) 2015/11/06 20:40:36 Do you need the FrameLayout? Looks like you could
megjablon 2015/11/06 23:41:40 Adding the padding to the checkbox directly moves
newt (away) 2015/11/07 00:43:34 Ah, I was worried that padding might interfere wit
+ android:id="@+id/data_use_checkbox"
+ android:layout_height="wrap_content"
+ android:layout_width="fill_parent"
newt (away) 2015/11/06 20:40:36 match_parent
megjablon 2015/11/06 23:41:40 Done.
+ android:text="@string/data_use_tracking_ended_checkbox_message" />
+
+</FrameLayout>

Powered by Google App Engine
This is Rietveld 408576698