chrome/android/java/res/layout/data_use_dialog.xml - Issue 1418473005: Add a dialog UI for Data Use accounting

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/data_use_dialog.xml

Issue 1418473005: Add a dialog UI for Data Use accounting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@freighterSnackbar

Patch Set: remove we Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/datausage/DataUseTabUIManager.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
	newt (away) 2015/11/06 20:40:36 missing copyright missing copyright megjablon 2015/11/06 23:41:40 Done. Show quoted text On 2015/11/06 20:40:36, newt wrote: > missing copyright Done.
	2 android:layout_height="wrap_content"

	3 android:layout_width="fill_parent"
	newt (away) 2015/11/06 20:40:36 s/fill_parent/match_parent/ (they mean the same th s/fill_parent/match_parent/ (they mean the same thing, but we use match_parent for consistency) megjablon 2015/11/06 23:41:40 Done. Show quoted text On 2015/11/06 20:40:36, newt wrote: > s/fill_parent/match_parent/ (they mean the same thing, but we use match_parent > for consistency) Done.
	4 android:paddingStart="18dp"

	5 android:paddingTop="8dp" >

	6

	7 <CheckBox
	newt (away) 2015/11/06 20:40:36 Do you need the FrameLayout? Looks like you could Do you need the FrameLayout? Looks like you could just add padding to the CheckBox and remove the FrameLayout. megjablon 2015/11/06 23:41:40 Adding the padding to the checkbox directly moves Show quoted text On 2015/11/06 20:40:36, newt wrote: > Do you need the FrameLayout? Looks like you could just add padding to the > CheckBox and remove the FrameLayout. Adding the padding to the checkbox directly moves the text placement, but not checkbox. Using layout_margin seems to be overriden when setting the view. I could remove the FrameLayout and use the setView that takes spacing values, but that would mean calculating the dp to px values when the dialog is displayed and this seems simpler. newt (away) 2015/11/07 00:43:34 Ah, I was worried that padding might interfere wit Show quoted text On 2015/11/06 23:41:40, megjablon wrote: > On 2015/11/06 20:40:36, newt wrote: > > Do you need the FrameLayout? Looks like you could just add padding to the > > CheckBox and remove the FrameLayout. > > Adding the padding to the checkbox directly moves the text placement, but not > checkbox. Using layout_margin seems to be overriden when setting the view. I > could remove the FrameLayout and use the setView that takes spacing values, but > that would mean calculating the dp to px values when the dialog is displayed and > this seems simpler. Ah, I was worried that padding might interfere with checkbox positioning. Just keep the FrameLayout as it is.
	8 android:id="@+id/data_use_checkbox"

	9 android:layout_height="wrap_content"

	10 android:layout_width="fill_parent"
	newt (away) 2015/11/06 20:40:36 match_parent match_parent megjablon 2015/11/06 23:41:40 Done. Show quoted text On 2015/11/06 20:40:36, newt wrote: > match_parent Done.
	11 android:text="@string/data_use_tracking_ended_checkbox_message" />

	12

	13 </FrameLayout>

OLD	NEW