Move UrlBar background drawing to CC.

Move UrlBar background drawing to CC.

BUG=482207
Committed: https://crrev.com/62266f51cd81926c307b2674018a292a0e39cd14
Cr-Commit-Position: refs/heads/master@{#357436}

[aurimas (slooooooooow), 2015-10-28 17:26:05]

aurimas@chromium.org changed reviewers:
+ dtrainor@chromium.org, yusufo@chromium.org

[aurimas (slooooooooow), 2015-10-28 17:26:05]

PTAL

[aurimas (slooooooooow), 2015-10-29 15:47:42]

ping?

http://i.imgur.com/nEyqyEg.jpg

[aurimas (slooooooooow), 2015-10-29 18:47:23]

aurimas@chromium.org changed reviewers:
+ tedchoc@chromium.org

[aurimas (slooooooooow), 2015-10-29 18:47:24]

+tedchoc for ToolbarPhone changes.

[aurimas (slooooooooow), 2015-10-29 18:51:02]

Description was changed from

==========
Move UrlBar background drawing to CC.

BUG=
==========

to

==========
Move UrlBar background drawing to CC.

BUG=482207
==========

[Ted C, 2015-10-29 22:54:16]

On 2015/10/29 18:47:24, aurimas wrote:
> +tedchoc for ToolbarPhone changes.

ToolbarPhone - lgtm

[Yusuf, 2015-10-29 22:55:44]

lgtm for everything except toolbar_layer.cc. That one I am not 100% familiar
with.

https://chromiumcodereview.appspot.com/1417353003/diff/60001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java
(right):

https://chromiumcodereview.appspot.com/1417353003/diff/60001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java:265:
float textBoxAlpha =
ColorUtils.getTextBoxAlphaForToolbarBackground(tab.getThemeColor());
I would say cash the color here and call ColorUtils directly without cashing the
alpha here like we do for the color.

[aurimas (slooooooooow), 2015-10-30 18:31:53]

https://chromiumcodereview.appspot.com/1417353003/diff/60001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java
(right):

https://chromiumcodereview.appspot.com/1417353003/diff/60001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java:265:
float textBoxAlpha =
ColorUtils.getTextBoxAlphaForToolbarBackground(tab.getThemeColor());
On 2015/10/29 at 22:55:44, Yusuf wrote:
> I would say cash the color here and call ColorUtils directly without cashing
the alpha here like we do for the color.

Done

[David Trainor- moved to gerrit, 2015-11-02 16:25:08]

just two nits, but lgtm.

https://chromiumcodereview.appspot.com/1417353003/diff/100001/chrome/android/...
File
chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java
(right):

https://chromiumcodereview.appspot.com/1417353003/diff/100001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java:659:
private void updateUrlViewportBounds(Rect urlViewPortBounds, VisualState
visualState,
I might add a javadoc to this or rename urlViewPortBounds as an out parameter? 
Something to explain that those bounds will be mutated.  I donno.

https://chromiumcodereview.appspot.com/1417353003/diff/100001/chrome/browser/...
File chrome/browser/android/compositor/layer/toolbar_layer.h (right):

https://chromiumcodereview.appspot.com/1417353003/diff/100001/chrome/browser/...
chrome/browser/android/compositor/layer/toolbar_layer.h:57: ui::ResourceManager*
resource_manager_;
If we're going to save the resource manager, we might not want to pass the
actual Resource in PushResource.  Might as well push IDs for everything.

[aurimas (slooooooooow), 2015-11-02 19:31:46]

https://chromiumcodereview.appspot.com/1417353003/diff/100001/chrome/android/...
File
chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java
(right):

https://chromiumcodereview.appspot.com/1417353003/diff/100001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java:659:
private void updateUrlViewportBounds(Rect urlViewPortBounds, VisualState
visualState,
On 2015/11/02 at 16:25:08, David Trainor wrote:
> I might add a javadoc to this or rename urlViewPortBounds as an out parameter?
 Something to explain that those bounds will be mutated.  I donno.

Done

https://chromiumcodereview.appspot.com/1417353003/diff/100001/chrome/browser/...
File chrome/browser/android/compositor/layer/toolbar_layer.h (right):

https://chromiumcodereview.appspot.com/1417353003/diff/100001/chrome/browser/...
chrome/browser/android/compositor/layer/toolbar_layer.h:57: ui::ResourceManager*
resource_manager_;
On 2015/11/02 at 16:25:08, David Trainor wrote:
> If we're going to save the resource manager, we might not want to pass the
actual Resource in PushResource.  Might as well push IDs for everything.

Done

[aurimas (slooooooooow), 2015-11-02 19:31:55]

The CQ bit was checked by aurimas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-02 19:36:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417353003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417353003/120001

[commit-bot: I haz the power, 2015-11-02 20:13:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-02 20:13:10]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[aurimas (slooooooooow), 2015-11-02 21:04:16]

The CQ bit was checked by aurimas@chromium.org

[aurimas (slooooooooow), 2015-11-02 21:04:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, yusufo@chromium.org, dtrainor@chromium.org
Link to the patchset:
https://chromiumcodereview.appspot.com/1417353003/#ps140001 (title: "Fix tests
compile issue")

[commit-bot: I haz the power, 2015-11-02 21:05:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417353003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417353003/140001

[commit-bot: I haz the power, 2015-11-02 21:51:56]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2015-11-02 21:53:05]

Patchset 8 (id:??) landed as
https://crrev.com/62266f51cd81926c307b2674018a292a0e39cd14
Cr-Commit-Position: refs/heads/master@{#357436}