chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java - Issue 1417353003: Move UrlBar background drawing to CC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java

Issue 1417353003: Move UrlBar background drawing to CC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix tests compile issue Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutRenderHost.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java

index 081d972a730c5d4c2877d847c83f01e5cd5ae6eb..289b348697a2e9ad9d28413a4f4bc4412d3e3f09 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java

@@ -262,11 +262,13 @@ public class LayoutManagerDocument extends LayoutManager

String url = tab.getUrl();

boolean isNativePage = url != null && url.startsWith(UrlConstants.CHROME_NATIVE_SCHEME);

+ int themeColor = tab.getThemeColor();

boolean canUseLiveTexture =

tab.getContentViewCore() != null && !tab.isShowingSadTab() && !isNativePage;

layoutTab.initFromHost(tab.getBackgroundColor(), tab.shouldStall(), canUseLiveTexture,

- tab.getThemeColor(),

- ColorUtils.getTextBoxColorForToolbarBackground(tab.getThemeColor()));

+ themeColor,

+ ColorUtils.getTextBoxColorForToolbarBackground(themeColor),

+ ColorUtils.getTextBoxAlphaForToolbarBackground(tab));

mHost.requestRender();

}