[Android] Rename NativeWindow to WindowAndroid.

[Android] Rename NativeWindow to WindowAndroid.

Renaming NativeWindow to WindowAndroid for consistency with C++ name of window_android.

Also removing AwNativeWindow as according to joth@ it is no longer isued in WebView.

BUG=233064
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195101

[aurimas (slooooooooow), 2013-04-18 04:31:58]

Hello Jonathan,

Please take a look at this CL. I am also removing AwNativeWindow as you said it
is unused in WebView.

Thanks,
Aurimas

[aurimas (slooooooooow), 2013-04-18 06:15:30]

Hello Nilesh,

Please take a look at this change. I am separating the rename of NativeWindow
away from the https://chromiumcodereview.appspot.com/14018004/ CL into this CL.

Thanks,
Aurimas

[nilesh, 2013-04-18 16:50:06]

https://chromiumcodereview.appspot.com/14169011/diff/3001/chrome/android/java...
File
chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopup.java
(right):

https://chromiumcodereview.appspot.com/14169011/diff/3001/chrome/android/java...
chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopup.java:125:
* @param windowAndroid WindowAndroid used to get application context.
It says it needs the application context but getting the activity one.

https://chromiumcodereview.appspot.com/14169011/diff/3001/chrome/android/java...
chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopup.java:132:
mWindowAndroid = windowAndroid;
Why store a ref to window, when only application context is needed.

https://chromiumcodereview.appspot.com/14169011/diff/3001/ui/android/java/src...
File ui/android/java/src/org/chromium/ui/WindowAndroid.java (right):

https://chromiumcodereview.appspot.com/14169011/diff/3001/ui/android/java/src...
ui/android/java/src/org/chromium/ui/WindowAndroid.java:174: public Context
getContext() {
Do we need to give away the activity context?
Please have two methods getApplicationContext and getActivityContext, and make
callers explicitly call for getActivityContext (when needed_ _ ) with usual
warnings of having a long lived references to the activity context. 
Not having a getActivityContext is even better.

https://chromiumcodereview.appspot.com/14169011/diff/3001/ui/android/ui_jni_r...
File ui/android/ui_jni_registrar.cc (right):

https://chromiumcodereview.appspot.com/14169011/diff/3001/ui/android/ui_jni_r...
ui/android/ui_jni_registrar.cc:23: { "Clipboard", ui::RegisterClipboardAndroid
},
You can move Clipboard to the top.

[joth, 2013-04-18 17:15:30]

+benm for second opinion, but AFAIK we should never hit any of the
contentviewcore native window using paths now.

The rename lgtm for aw/

[benm (inactive), 2013-04-18 19:40:04]

lgtm

yes, afaict the only content/ user of it would be the ui for chrome://tracing,
which we don't have on webview.

IIRC the issue we had before was that ContentViewCore couldn't handle a NULL
NativeWindow, and instantiating the NativeWindow that Chrome used didn't work
either (but I don't recall what exactly the issue was)

https://chromiumcodereview.appspot.com/14169011/diff/3001/android_webview/jav...
File android_webview/java/src/org/chromium/android_webview/AwContents.java
(right):

https://chromiumcodereview.appspot.com/14169011/diff/3001/android_webview/jav...
android_webview/java/src/org/chromium/android_webview/AwContents.java:46: import
org.chromium.ui.WindowAndroid;
can we remove this import?

[benm (inactive), 2013-04-18 19:40:42]

as in lgtm for android_webview, didn't pay too much attention to the remainder
of the change.

On 2013/04/18 19:40:04, benm wrote:
> lgtm
> 
> yes, afaict the only content/ user of it would be the ui for chrome://tracing,
> which we don't have on webview.
> 
> IIRC the issue we had before was that ContentViewCore couldn't handle a NULL
> NativeWindow, and instantiating the NativeWindow that Chrome used didn't work
> either (but I don't recall what exactly the issue was)
> 
>
https://chromiumcodereview.appspot.com/14169011/diff/3001/android_webview/jav...
> File android_webview/java/src/org/chromium/android_webview/AwContents.java
> (right):
> 
>
https://chromiumcodereview.appspot.com/14169011/diff/3001/android_webview/jav...
> android_webview/java/src/org/chromium/android_webview/AwContents.java:46:
import
> org.chromium.ui.WindowAndroid;
> can we remove this import?

[aurimas (slooooooooow), 2013-04-18 20:46:15]

https://chromiumcodereview.appspot.com/14169011/diff/3001/android_webview/jav...
File android_webview/java/src/org/chromium/android_webview/AwContents.java
(right):

https://chromiumcodereview.appspot.com/14169011/diff/3001/android_webview/jav...
android_webview/java/src/org/chromium/android_webview/AwContents.java:46: import
org.chromium.ui.WindowAndroid;
On 2013/04/18 19:40:04, benm wrote:
> can we remove this import?

Done.

https://chromiumcodereview.appspot.com/14169011/diff/3001/chrome/android/java...
File
chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopup.java
(right):

https://chromiumcodereview.appspot.com/14169011/diff/3001/chrome/android/java...
chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopup.java:125:
* @param windowAndroid WindowAndroid used to get application context.
On 2013/04/18 16:50:06, nilesh wrote:
> It says it needs the application context but getting the activity one.

It was a mistake in the comment. I wrote this comment. Fixed

https://chromiumcodereview.appspot.com/14169011/diff/3001/chrome/android/java...
chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopup.java:132:
mWindowAndroid = windowAndroid;
On 2013/04/18 16:50:06, nilesh wrote:
> Why store a ref to window, when only application context is needed.

Done.

https://chromiumcodereview.appspot.com/14169011/diff/3001/ui/android/java/src...
File ui/android/java/src/org/chromium/ui/WindowAndroid.java (right):

https://chromiumcodereview.appspot.com/14169011/diff/3001/ui/android/java/src...
ui/android/java/src/org/chromium/ui/WindowAndroid.java:174: public Context
getContext() {
On 2013/04/18 16:50:06, nilesh wrote:
> Do we need to give away the activity context?
> Please have two methods getApplicationContext and getActivityContext, and make
> callers explicitly call for getActivityContext (when needed_ _ ) with usual
> warnings of having a long lived references to the activity context. 
> Not having a getActivityContext is even better.

Done.

https://chromiumcodereview.appspot.com/14169011/diff/3001/ui/android/ui_jni_r...
File ui/android/ui_jni_registrar.cc (right):

https://chromiumcodereview.appspot.com/14169011/diff/3001/ui/android/ui_jni_r...
ui/android/ui_jni_registrar.cc:23: { "Clipboard", ui::RegisterClipboardAndroid
},
On 2013/04/18 16:50:06, nilesh wrote:
> You can move Clipboard to the top.

Done.

[aurimas (slooooooooow), 2013-04-18 20:53:05]

Hey Ted,

Please take a look at this CL.

Aurimas

[nilesh, 2013-04-18 21:02:13]

lgtm with comments.

https://chromiumcodereview.appspot.com/14169011/diff/19001/chrome/android/jav...
File
chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopup.java
(right):

https://chromiumcodereview.appspot.com/14169011/diff/19001/chrome/android/jav...
chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopup.java:125:
* @param context Activity context.
Application context.

https://chromiumcodereview.appspot.com/14169011/diff/19001/ui/android/java/sr...
File ui/android/java/src/org/chromium/ui/WindowAndroid.java (right):

https://chromiumcodereview.appspot.com/14169011/diff/19001/ui/android/java/sr...
ui/android/java/src/org/chromium/ui/WindowAndroid.java:101: public Activity
getActivity() {
Is anyone calling this? Please remove if not.

[Ted C, 2013-04-18 21:03:03]

lgtm w/ after addressing Nilesh's comments

[aurimas (slooooooooow), 2013-04-18 21:22:58]

https://chromiumcodereview.appspot.com/14169011/diff/19001/chrome/android/jav...
File
chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopup.java
(right):

https://chromiumcodereview.appspot.com/14169011/diff/19001/chrome/android/jav...
chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopup.java:125:
* @param context Activity context.
On 2013/04/18 21:02:14, nilesh wrote:
> Application context.

Done.

https://chromiumcodereview.appspot.com/14169011/diff/19001/ui/android/java/sr...
File ui/android/java/src/org/chromium/ui/WindowAndroid.java (right):

https://chromiumcodereview.appspot.com/14169011/diff/19001/ui/android/java/sr...
ui/android/java/src/org/chromium/ui/WindowAndroid.java:101: public Activity
getActivity() {
On 2013/04/18 21:02:14, nilesh wrote:
> Is anyone calling this? Please remove if not.

Good point, I was used in SelectFileDialogAndroid before, but I refactored that
class so only WindowAndroid needs access to Activity

[aurimas (slooooooooow), 2013-04-18 21:26:15]

Hello Scott,

Please take a look at the ui/* changes.

Thanks!
Aurimas

[aurimas (slooooooooow), 2013-04-18 22:19:36]

-sky

+thakis: sky is OOO, could you take a look at changes in ui/*

Thanks,
Aurimas

[Nico, 2013-04-18 22:25:50]

ui/ lgtm

[commit-bot: I haz the power, 2013-04-18 22:32:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aurimas@chromium.org/14169011/26003

[commit-bot: I haz the power, 2013-04-19 01:25:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aurimas@chromium.org/14169011/40003

[commit-bot: I haz the power, 2013-04-19 04:56:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aurimas@chromium.org/14169011/40003

[commit-bot: I haz the power, 2013-04-19 08:38:14]

Change committed as 195101