[Android] Rename NativeWindow to WindowAndroid.

chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopup.java

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.autofill;
 
 import android.content.Context;
 import android.content.res.Configuration;
 import android.graphics.Paint;
 import android.graphics.Point;
 import android.graphics.Rect;
 import android.graphics.drawable.Drawable;
-import android.util.Log;
 import android.view.LayoutInflater;
 import android.view.View;
 import android.view.WindowManager;
 import android.widget.AdapterView;
 import android.widget.FrameLayout;
-import android.widget.ListAdapter;
 import android.widget.ListPopupWindow;
 import android.widget.TextView;
 
 import java.util.ArrayList;
 
 import org.chromium.chrome.R;
 import org.chromium.content.browser.ContainerViewDelegate;
 import org.chromium.ui.gfx.DeviceDisplayInfo;
-import org.chromium.ui.gfx.NativeWindow;
+import org.chromium.ui.WindowAndroid;
 
 /**
  * The Autofill suggestion popup that lists relevant suggestions.
  */
 public class AutofillPopup extends ListPopupWindow implements AdapterView.OnItemClickListener {
 
     /**
      * Constants defining types of Autofill suggestion entries.
      * Has to be kept in sync with enum in WebAutofillClient.h
      *
      * Not supported: MenuItemIDWarningMessage, MenuItemIDSeparator, MenuItemIDClearForm, and
      * MenuItemIDAutofillOptions.
      */
     private static final int ITEM_ID_AUTOCOMPLETE_ENTRY = 0;
     private static final int ITEM_ID_PASSWORD_ENTRY = -2;
     private static final int ITEM_ID_DATA_LIST_ENTRY = -6;
 
     private static final int TEXT_PADDING_DP = 30;
 
     private final AutofillPopupDelegate mAutofillCallback;
-    private final NativeWindow mNativeWindow;
+    private final WindowAndroid mWindowAndroid;
     private final ContainerViewDelegate mContainerViewDelegate;
     private AnchorView mAnchorView;
     private Rect mAnchorRect;
     private Paint mNameViewPaint;
     private Paint mLabelViewPaint;
 
     /**
      * An interface to handle the touch interaction with an AutofillPopup object.
      */
     public interface AutofillPopupDelegate {
@@ skipping 57 matching lines @@
 
             FrameLayout.LayoutParams lp = new FrameLayout.LayoutParams(width, height);
             lp.leftMargin = r.left - paddingRect.left;
             lp.topMargin = r.top;
             setLayoutParams(lp);
         }
     }
 
     /**
      * Creates an AutofillWindow with specified parameters.
-     * @param nativeWindow NativeWindow used to get application context.
+     * @param windowAndroid WindowAndroid used to get application context.

[nilesh, 2013/04/18 16:50:06]

It says it needs the application context but getting the activity one.

[aurimas (slooooooooow), 2013/04/18 20:46:16]

It was a mistake in the comment. I wrote this comment. Fixed

      * @param containerViewDelegate View delegate used to add and remove views.
      * @param autofillCallback A object that handles the calls to the native AutofillPopupView.
      */
-    public AutofillPopup(NativeWindow nativeWindow, ContainerViewDelegate containerViewDelegate,
+    public AutofillPopup(WindowAndroid windowAndroid, ContainerViewDelegate containerViewDelegate,
             AutofillPopupDelegate autofillCallback) {
-        super(nativeWindow.getContext());
-        mNativeWindow = nativeWindow;
+        super(windowAndroid.getContext());
+        mWindowAndroid = windowAndroid;

[nilesh, 2013/04/18 16:50:06]

Why store a ref to window, when only application context is needed.

[aurimas (slooooooooow), 2013/04/18 20:46:16]

Done.

         mContainerViewDelegate = containerViewDelegate;
         mAutofillCallback = autofillCallback;
 
         setOnItemClickListener(this);
 
-        mAnchorView = new AnchorView(mNativeWindow.getContext(), this);
+        mAnchorView = new AnchorView(mWindowAndroid.getContext(), this);
         mContainerViewDelegate.addViewToContainerView(mAnchorView);
         setAnchorView(mAnchorView);
     }
 
     /**
      * Sets the location and the size of the anchor view that the AutofillPopup will use to attach
      * itself.
      * @param x X coordinate of the top left corner of the anchor view.
      * @param y Y coordinate of the top left corner of the anchor view.
      * @param width The width of the anchor view.
      * @param height The height of the anchor view.
      */
     public void setAnchorRect(float x, float y, float width, float height) {
-        float scale = (float) DeviceDisplayInfo.create(mNativeWindow.getContext()).getDIPScale();
+        float scale = (float) DeviceDisplayInfo.create(mWindowAndroid.getContext()).getDIPScale();
         mAnchorRect = new Rect(Math.round(x * scale), Math.round(y * scale),
                 Math.round((x + width) * scale), Math.round((y + height) * scale));
         mAnchorRect.offset(0, mContainerViewDelegate.getChildViewOffsetYPix());
     }
 
     /**
      * Sets the Autofill suggestions to display in the popup and shows the popup.
      * @param suggestions Autofill suggestion data.
      */
     public void show(AutofillSuggestion[] suggestions) {
         // Remove the AutofillSuggestions with IDs that are not supported by Android
         ArrayList<AutofillSuggestion> cleanedData = new ArrayList<AutofillSuggestion>();
         for (int i = 0; i < suggestions.length; i++) {
             int itemId = suggestions[i].mUniqueId;
             if (itemId > 0 || itemId == ITEM_ID_AUTOCOMPLETE_ENTRY ||
                     itemId == ITEM_ID_PASSWORD_ENTRY || itemId == ITEM_ID_DATA_LIST_ENTRY) {
                 cleanedData.add(suggestions[i]);
             }
         }
-        setAdapter(new AutofillListAdapter(mNativeWindow.getContext(), cleanedData));
+        setAdapter(new AutofillListAdapter(mWindowAndroid.getContext(), cleanedData));
         // Once the mAnchorRect is resized and placed correctly, it will show the Autofill popup.
         mAnchorView.setSize(mAnchorRect, getDesiredWidth(suggestions));
     }
 
 
     /**
      * Overrides the default dismiss behavior to request the controller to dismiss the view.
      */
     @Override
     public void dismiss() {
         mAutofillCallback.requestHide();
     }
 
     /**
      * Hides the popup and removes the anchor view from the ContainerView.
      */
     public void hide() {
         super.dismiss();
         mContainerViewDelegate.removeViewFromContainerView(mAnchorView);
     }
 
     /**
      * Get desired popup window width by calculating the maximum text length from Autofill data.
      * @param data Autofill suggestion data.
      * @return The popup window width.
      */
     private int getDesiredWidth(AutofillSuggestion[] data) {
         if (mNameViewPaint == null || mLabelViewPaint == null) {
             LayoutInflater inflater =
-                    (LayoutInflater) mNativeWindow.getContext().getSystemService(
+                    (LayoutInflater) mWindowAndroid.getContext().getSystemService(
                             Context.LAYOUT_INFLATER_SERVICE);
             View layout = inflater.inflate(R.layout.autofill_text, null);
             TextView nameView = (TextView) layout.findViewById(R.id.autofill_name);
             mNameViewPaint = nameView.getPaint();
             TextView labelView = (TextView) layout.findViewById(R.id.autofill_label);
             mLabelViewPaint = labelView.getPaint();
         }
 
         int maxTextWidth = 0;
         Rect bounds = new Rect();
         for (int i = 0; i < data.length; ++i) {
             bounds.setEmpty();
             String name = data[i].mName;
             int width = 0;
             mNameViewPaint.getTextBounds(name, 0, name.length(), bounds);
             width += bounds.width();
 
             bounds.setEmpty();
             String label = data[i].mLabel;
             mLabelViewPaint.getTextBounds(label, 0, label.length(), bounds);
             width += bounds.width();
             maxTextWidth = Math.max(width, maxTextWidth);
         }
         // Adding padding.
         return maxTextWidth + (int) (TEXT_PADDING_DP *
-                mNativeWindow.getContext().getResources().getDisplayMetrics().density);
+                mWindowAndroid.getContext().getResources().getDisplayMetrics().density);
     }
 
     @Override
     public void onItemClick(AdapterView<?> parent, View view, int position, long id) {
         mAutofillCallback.suggestionSelected(position);
     }
 
 }