Fixed a bug that was introduced when we started deprecating 32bit libraries on 64bit systems.

Fixed a bug that was introduced when we started deprecating 32bit libraries on 64bit systems.

This needs a little bit of explanation. Normally, we would want to restructure
the code to have separate variables for "--lib32" and for the result of the
"yes_no" question. But that requires more global changes.

Instead, in this case, we want to very clearly document that we added an
early "if" statement to break out. And this is intended to be a temporary
measure until the entire feature is fully removed.

So, I instead opted for resetting the "do_inst_lib32" variable -- and a lengthy
comment explaining this decision.

BUG=233047
TEST=run with --lib32 and verify that entering "N" aborts the installation.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195950

[Michael Moss, 2013-04-23 16:02:30]

lgtm

https://codereview.chromium.org/14166013/diff/1/build/install-build-deps.sh
File build/install-build-deps.sh (right):

https://codereview.chromium.org/14166013/diff/1/build/install-build-deps.sh#n...
build/install-build-deps.sh:302: # remove support for 32bit libraries on 64bit
systems. But for the time being,
nit: 80 chars here and next line.

[Markus (顧孟勤), 2013-04-23 18:05:48]

https://codereview.chromium.org/14166013/diff/1/build/install-build-deps.sh
File build/install-build-deps.sh (right):

https://codereview.chromium.org/14166013/diff/1/build/install-build-deps.sh#n...
build/install-build-deps.sh:302: # remove support for 32bit libraries on 64bit
systems. But for the time being,
On 2013/04/23 16:02:30, Michael Moss wrote:
> nit: 80 chars here and next line.

Done.

[commit-bot: I haz the power, 2013-04-23 19:30:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/markus@chromium.org/14166013/5001

[commit-bot: I haz the power, 2013-04-24 00:11:28]

Change committed as 195950

[Peter Mayo, 2013-09-26 17:53:15]

https://chromiumcodereview.appspot.com/14166013/diff/5001/build/install-build...
File build/install-build-deps.sh (right):

https://chromiumcodereview.appspot.com/14166013/diff/5001/build/install-build...
build/install-build-deps.sh:313: # allow us to gradually deprecate and then
remove the obsolete code.
Ignoring the --no_prompt option?

The "special" bots includes the entire chromeos build fleet.

Going around to each one with a temrinal session option is a surprising fdrain
on time and resources today.