Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Unified Diff: build/install-build-deps.sh

Issue 14166013: Fixed a bug that was introduced when we started deprecating 32bit libraries on 64bit systems. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rewrapped Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/install-build-deps.sh
diff --git a/build/install-build-deps.sh b/build/install-build-deps.sh
index 757c54520fa219cd385b06e4c2cdefed120a718f..382fc11860b1c1df6dc212392ae32e1361b14ddc 100755
--- a/build/install-build-deps.sh
+++ b/build/install-build-deps.sh
@@ -297,6 +297,21 @@ if [ "$(uname -m)" = "x86_64" ]; then
echo
echo "Installation complete."
exit 0
+ else
+ # This conditional statement has been added to deprecate and eventually
+ # remove support for 32bit libraries on 64bit systems. But for the time
+ # being, we still have to support a few legacy systems (e.g. bots), where
+ # this feature is needed.
+ # We only even give the user the option to install these libraries, if
+ # they explicitly requested doing so by setting the --lib32 command line
+ # flag.
+ # And even then, we interactively ask them one more time whether they are
+ # absolutely sure.
+ # In order for that to work, we must reset the ${do_inst_lib32} variable.
+ # There are other ways to achieve the same goal. But resetting the
+ # variable is the best way to document the intended behavior -- and to
+ # allow us to gradually deprecate and then remove the obsolete code.
Peter Mayo 2013/09/26 17:53:15 Ignoring the --no_prompt option? The "special" bo
+ do_inst_lib32=
fi
echo "WARNING"
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698