Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 14147005: Remove HTMLInputElement::isTextFormControlFocusable. (Closed)

Created:
7 years, 8 months ago by tkent
Modified:
7 years, 8 months ago
Reviewers:
pdr., eseidel
CC:
blink-reviews, ojan
Visibility:
Public.

Description

Remove HTMLInputElement::isTextFormControlFocusable. It is used by InputTypes to call HTMLTextFormControlElement::isFocusable. However HTMLInputElement doesn't override isFocusable, and we don't have any reason to call isFocusable of the parent class of HTMLInputElement. InputTypes can call HTMLInputElement::isFocusable directly. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148337

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -10 lines) Patch
M Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/WebCore/html/HTMLInputElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/html/HTMLInputElement.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/WebCore/html/TextFieldInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tkent
7 years, 8 months ago (2013-04-14 22:06:53 UTC) #1
pdr.
On 2013/04/14 22:06:53, tkent wrote: LGTM
7 years, 8 months ago (2013-04-14 22:11:27 UTC) #2
commit-bot: I haz the power
No reviewers yet.
7 years, 8 months ago (2013-04-14 22:14:32 UTC) #3
tkent
7 years, 8 months ago (2013-04-14 22:17:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/14147005/1
7 years, 8 months ago (2013-04-14 22:17:24 UTC) #5
commit-bot: I haz the power
Change committed as 148337
7 years, 8 months ago (2013-04-14 22:17:36 UTC) #6
haraken
On 2013/04/14 22:17:36, I haz the power (commit-bot) wrote: > Change committed as 148337 Rolled ...
7 years, 8 months ago (2013-04-15 08:10:49 UTC) #7
eseidel
7 years, 8 months ago (2013-04-17 01:57:04 UTC) #8
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698